You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/12/28 15:55:49 UTC

[jira] [Commented] (SOLR-8340) HighlightComponent throws a NullPointerException when the attribute of ResponseBuilder which named 'onePassDistributedQuery' is 'true' and 'rows' is greater than zero

    [ https://issues.apache.org/jira/browse/SOLR-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072776#comment-15072776 ] 

ASF subversion and git services commented on SOLR-8340:
-------------------------------------------------------

Commit 1721931 from [~dsmiley] in branch 'dev/branches/lucene_solr_5_3'
[ https://svn.apache.org/r1721931 ]

SOLR-8059 SOLR-8340: Fix HighlightComponent & DebugComponent finishStage NPE's when distrib.singlePass

> HighlightComponent throws a NullPointerException when the attribute of ResponseBuilder which named 'onePassDistributedQuery' is 'true' and 'rows' is greater than zero
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8340
>                 URL: https://issues.apache.org/jira/browse/SOLR-8340
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>    Affects Versions: 5.3.1
>            Reporter: zengjie
>            Assignee: Christine Poerschke
>            Priority: Critical
>              Labels: highlighting
>             Fix For: 5.4, Trunk
>
>         Attachments: solr.patch
>
>
>  When the attribute 'onePassDistributedQuery' is 'true',QueryCompoent will not  send a ShardRequest to retrive field values, highlight values has been return by shards in createMainQuery together.
> See code below:
>  private void handleRegularResponses(ResponseBuilder rb, ShardRequest sreq) {
>     if ((sreq.purpose & ShardRequest.PURPOSE_GET_TOP_IDS) != 0) {
> //merge all id and score,and ResponseBuilder.resultIds just stored id between start to rows
>       mergeIds(rb, sreq);
>     }
>     if ((sreq.purpose & ShardRequest.PURPOSE_GET_TERM_STATS) != 0) {
>       updateStats(rb, sreq);
>     }
>     if ((sreq.purpose & ShardRequest.PURPOSE_GET_FIELDS) != 0) {
> //where ResponseBuilder.onePassDistributedQuery is true,highlight values was retrived at same time,but not truncated by 'start' and 'rows',just return top N(N=start+rows),
>       returnFields(rb, sreq);
>     }
>   }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org