You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/26 02:32:24 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10427: chore: Cleanup database sessions
codecov-commenter edited a comment on pull request #10427:
URL: https://github.com/apache/incubator-superset/pull/10427#issuecomment-663927562
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10427?src=pr&el=h1) Report
> Merging [#10427](https://codecov.io/gh/apache/incubator-superset/pull/10427?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea3c3bbae4d5e6f9ef0ca3f66b7e8ed67367d614&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `68.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10427?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10427 +/- ##
==========================================
+ Coverage 70.26% 70.30% +0.04%
==========================================
Files 605 605
Lines 32425 32390 -35
Branches 3295 3295
==========================================
- Hits 22784 22773 -11
+ Misses 9532 9510 -22
+ Partials 109 107 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.82% <ø> (+0.24%)` | :arrow_up: |
| #javascript | `59.27% <ø> (ø)` | |
| #python | `69.71% <68.15%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10427?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `39.73% <0.00%> (+0.13%)` | :arrow_up: |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.86% <0.00%> (+0.47%)` | :arrow_up: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `93.44% <ø> (ø)` | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | `61.82% <20.00%> (+0.26%)` | :arrow_up: |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `91.17% <33.33%> (-0.09%)` | :arrow_down: |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `60.71% <40.00%> (ø)` | |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `63.96% <42.85%> (+2.75%)` | :arrow_up: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `89.03% <50.00%> (+0.72%)` | :arrow_up: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `84.54% <50.00%> (+0.40%)` | :arrow_up: |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `55.81% <57.14%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/incubator-superset/pull/10427/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10427?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10427?src=pr&el=footer). Last update [ea3c3bb...e72bca2](https://codecov.io/gh/apache/incubator-superset/pull/10427?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org