You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2014/04/15 00:19:53 UTC
Review Request 20343: WIP: Force reload of the JS files only in MSIE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
- use the User-Agent header to get the client type
- only use the cache workaround if the browser is MSIE, use standard cache control headers anyway
Diffs
-----
ui/index.jsp 5840e71
utils/pom.xml cc6de3b
utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION
utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/20343/diff/
Testing
-------
-unit testing
-tests with firefox
TODO:
- tests with IE
- tests with modified files
Thanks,
Laszlo Hornyak
Re: Review Request 20343: WIP: Force reload of the JS files only in
MSIE
Posted by Laszlo Hornyak <la...@gmail.com>.
> On Dec. 5, 2014, 6:03 p.m., Rohit Yadav wrote:
> > Hey Laszlo, that's a nice feature please advise if you want to submit a tested patch that applies on master or you want to close it?
> > Thanks.
Hi Rohit,
I plan to finish all tests in the next few weeks/days and send a fully tested version, however we can use github for the reviews, so I will just close this for now.
Thank you,
Laszlo
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/#review64025
-----------------------------------------------------------
On April 15, 2014, 6:13 a.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20343/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 6:13 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - use the User-Agent header to get the client type
> - only use the cache workaround if the browser is MSIE, use standard cache control headers anyway
>
>
> Diffs
> -----
>
> ui/index.jsp 5840e71
> utils/pom.xml cc6de3b
> utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION
> utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20343/diff/
>
>
> Testing
> -------
>
> -unit testing
> -tests with firefox
> - tests with IE
> - tests with modified files
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 20343: WIP: Force reload of the JS files only in
MSIE
Posted by Rohit Yadav <bh...@apache.org>.
> On Dec. 5, 2014, 6:03 p.m., Rohit Yadav wrote:
> > Hey Laszlo, that's a nice feature please advise if you want to submit a tested patch that applies on master or you want to close it?
> > Thanks.
>
> Laszlo Hornyak wrote:
> Hi Rohit,
>
> I plan to finish all tests in the next few weeks/days and send a fully tested version, however we can use github for the reviews, so I will just close this for now.
>
> Thank you,
> Laszlo
Great!
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/#review64025
-----------------------------------------------------------
On April 15, 2014, 6:13 a.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20343/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 6:13 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - use the User-Agent header to get the client type
> - only use the cache workaround if the browser is MSIE, use standard cache control headers anyway
>
>
> Diffs
> -----
>
> ui/index.jsp 5840e71
> utils/pom.xml cc6de3b
> utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION
> utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20343/diff/
>
>
> Testing
> -------
>
> -unit testing
> -tests with firefox
> - tests with IE
> - tests with modified files
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 20343: WIP: Force reload of the JS files only in
MSIE
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/#review64025
-----------------------------------------------------------
Hey Laszlo, that's a nice feature please advise if you want to submit a tested patch that applies on master or you want to close it?
Thanks.
- Rohit Yadav
On April 15, 2014, 6:13 a.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20343/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 6:13 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - use the User-Agent header to get the client type
> - only use the cache workaround if the browser is MSIE, use standard cache control headers anyway
>
>
> Diffs
> -----
>
> ui/index.jsp 5840e71
> utils/pom.xml cc6de3b
> utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION
> utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20343/diff/
>
>
> Testing
> -------
>
> -unit testing
> -tests with firefox
> - tests with IE
> - tests with modified files
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 20343: WIP: Force reload of the JS files only in MSIE
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/
-----------------------------------------------------------
(Updated April 15, 2014, 6:13 a.m.)
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
- use the User-Agent header to get the client type
- only use the cache workaround if the browser is MSIE, use standard cache control headers anyway
Diffs
-----
ui/index.jsp 5840e71
utils/pom.xml cc6de3b
utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION
utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/20343/diff/
Testing (updated)
-------
-unit testing
-tests with firefox
- tests with IE
- tests with modified files
Thanks,
Laszlo Hornyak
Re: Review Request 20343: WIP: Force reload of the JS files only in MSIE
Posted by Laszlo Hornyak <la...@gmail.com>.
> On April 15, 2014, 5:11 a.m., Rajani Karuturi wrote:
> > utils/src/com/cloud/utils/servlet/CacheControlUtil.java, line 24
> > <https://reviews.apache.org/r/20343/diff/1/?file=557372#file557372line24>
> >
> > Hi Laszlo,
> > Is there any reason to disable browser caching for IE?
> > I think we should just remove the t param for all the js files and let browsers cache them.
Hi Rajani,
I will check that again but I believe IE might be the reason why that t param is there. Actually I have ran into a couple of situations in other projects where IE did not send another request for the resource when only sending Last-Modified and ETag headers, so these resources remained outdated after page refresh.
- Laszlo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/#review40348
-----------------------------------------------------------
On April 15, 2014, 6:13 a.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20343/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 6:13 a.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - use the User-Agent header to get the client type
> - only use the cache workaround if the browser is MSIE, use standard cache control headers anyway
>
>
> Diffs
> -----
>
> ui/index.jsp 5840e71
> utils/pom.xml cc6de3b
> utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION
> utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20343/diff/
>
>
> Testing
> -------
>
> -unit testing
> -tests with firefox
> - tests with IE
> - tests with modified files
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 20343: WIP: Force reload of the JS files only in MSIE
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20343/#review40348
-----------------------------------------------------------
utils/src/com/cloud/utils/servlet/CacheControlUtil.java
<https://reviews.apache.org/r/20343/#comment73350>
Hi Laszlo,
Is there any reason to disable browser caching for IE?
I think we should just remove the t param for all the js files and let browsers cache them.
- Rajani Karuturi
On April 14, 2014, 10:19 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20343/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 10:19 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> - use the User-Agent header to get the client type
> - only use the cache workaround if the browser is MSIE, use standard cache control headers anyway
>
>
> Diffs
> -----
>
> ui/index.jsp 5840e71
> utils/pom.xml cc6de3b
> utils/src/com/cloud/utils/servlet/CacheControlUtil.java PRE-CREATION
> utils/test/com/cloud/utils/servlet/CacheControlUtilTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20343/diff/
>
>
> Testing
> -------
>
> -unit testing
> -tests with firefox
>
> TODO:
> - tests with IE
> - tests with modified files
>
>
> Thanks,
>
> Laszlo Hornyak
>
>