You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/12/01 17:54:51 UTC

Re: Review Request 63636: Added placeholder implementation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63636/#review192518
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/lambda.hpp
Lines 474-476 (patched)
<https://reviews.apache.org/r/63636/#comment270717>

    We should inherit from `lambda::Placeholder<N>` here,
    `is_placeholder` is expected to provide `::value` for example.



3rdparty/stout/include/stout/lambda.hpp
Lines 479-481 (patched)
<https://reviews.apache.org/r/63636/#comment270713>

    We shouldn't need this one.


- Michael Park


On Nov. 22, 2017, 6:13 a.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63636/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2017, 6:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added placeholder implementation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/lambda.hpp a61d97b69e7eebd057c94148d39c6e1fc3066017 
> 
> 
> Diff: https://reviews.apache.org/r/63636/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>