You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/01 16:45:52 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #10048:
[FLINK-14462][coordination] Remove JobGraph#allowQueuedScheduling flag
because it is always true
tillrohrmann commented on a change in pull request #10048: [FLINK-14462][coordination] Remove JobGraph#allowQueuedScheduling flag because it is always true
URL: https://github.com/apache/flink/pull/10048#discussion_r341654375
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java
##########
@@ -212,14 +154,12 @@ public void testScheduleWithDyingInstances() throws Exception {
// cannot get another slot, since all instances are dead
try {
- testingSlotProvider.allocateSlot(new ScheduledUnit(getDummyTask()), false, SlotProfile.noRequirements(), TestingUtils.infiniteTime()).get();
+ testingSlotProvider
+ .allocateSlot(new ScheduledUnit(getDummyTask()), SlotProfile.noRequirements(), TestingUtils.infiniteTime())
+ .get(2000L, TimeUnit.MILLISECONDS);
Review comment:
This change looks a bit weird. I think we only see the `TimeoutExeception` because of the `get(2000L, TimeUnit.MILLISECONDS)` and not from the `testingSlotProvider` because we use the `ComponentMainThreadExecutorServiceAdapter.forMainThread` which swallows the timeout of the slot allocation. I suggest to change this and to set a very low slot allocation timeout to fail fast.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services