You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "binhnguyenduc (via GitHub)" <gi...@apache.org> on 2023/06/22 08:23:44 UTC

[GitHub] [superset] binhnguyenduc opened a new pull request, #24480: feat: add celeryConfigOverrides to allow extension for CeleryConfig object inside superset-config template

binhnguyenduc opened a new pull request, #24480:
URL: https://github.com/apache/superset/pull/24480

   ### SUMMARY
   We have an usecase to set up CeleryBeat for alerts and that need some configurations in CeleryConfig object. The current helm chart does not support extension to this. 
   
   So we use a similar mechanism as configOverrides to allow adding extra config to CeleryConfig.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   Render Helm chart by --dry-run to see that config values are indeed added to CeleryConfig. Non-breaking changes. Does not affect anyone who doesn't use the config
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org