[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1035: fix(update_replication_factor#12): update the mutation_2pc_min_replica_count base the max count of table

[GitBox <gi...@apache.org>]

foreverneverer commented on code in PR #1035:
URL: https://github.com/apache/incubator-pegasus/pull/1035#discussion_r916439512


##########
rdsn/src/common/replication_common.h:
##########
@@ -117,6 +117,11 @@ class replication_options
     ~replication_options();
 
     void initialize();
+
+    int32_t min_2pc_replica_count(int32_t app_max_replica_count)
+    {
+        return std::min(mutation_2pc_min_replica_count, app_max_replica_count) - 1;

Review Comment:
   yeah, the latest may be not pushed...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org