You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "John Kaputin (JIRA)" <ji...@apache.org> on 2007/08/13 17:05:31 UTC
[jira] Created: (WODEN-176) Remove the setParentElement method from
the API
Remove the setParentElement method from the API
-----------------------------------------------
Key: WODEN-176
URL: https://issues.apache.org/jira/browse/WODEN-176
Project: Woden
Issue Type: Bug
Reporter: John Kaputin
Assignee: John Kaputin
Fix For: M8
Attachments: setParentElement_src_changes.patch, setParentElement_test_changes.patch
Since WODEN-40, the Element API uses composition rather than aggregation. Elements have addXXXX methods that instantiate their child elements and set the parent element. It should no longer be necessary nor possible to set the parent element explicitly via the Woden API.
The setParentElement method should be removed from the NestedElement interface (so it just retains a getParentElement method) and the setParentElement methods implemented in package org.apache.woden.internal.wsdl20 should be given default access (package private) so that they are only available to the addXXXX methods within the WSDL impl classes.
The calls to setParentElement in the parseXXXX methods of BaseWSDLReader are redundant and should be removed. Some testcases also have redundant calls to setParentElement and those should be removed too. Providing the correct API programming model is used to instantiate objects (via the addXXXX methods), the parent element will always be initialised correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Closed: (WODEN-176) Remove the setParentElement method from
the API
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin closed WODEN-176.
------------------------------
> Remove the setParentElement method from the API
> -----------------------------------------------
>
> Key: WODEN-176
> URL: https://issues.apache.org/jira/browse/WODEN-176
> Project: Woden
> Issue Type: Bug
> Reporter: John Kaputin
> Assignee: John Kaputin
> Fix For: M8
>
> Attachments: setParentElement_src_changes.patch, setParentElement_test_changes.patch
>
>
> Since WODEN-40, the Element API uses composition rather than aggregation. Elements have addXXXX methods that instantiate their child elements and set the parent element. It should no longer be necessary nor possible to set the parent element explicitly via the Woden API.
> The setParentElement method should be removed from the NestedElement interface (so it just retains a getParentElement method) and the setParentElement methods implemented in package org.apache.woden.internal.wsdl20 should be given default access (package private) so that they are only available to the addXXXX methods within the WSDL impl classes.
> The calls to setParentElement in the parseXXXX methods of BaseWSDLReader are redundant and should be removed. Some testcases also have redundant calls to setParentElement and those should be removed too. Providing the correct API programming model is used to instantiate objects (via the addXXXX methods), the parent element will always be initialised correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-176) Remove the setParentElement method from
the API
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin updated WODEN-176:
-------------------------------
Attachment: setParentElement_test_changes.patch
setParentElement_src_changes.patch
Uploading src and test patch files.
> Remove the setParentElement method from the API
> -----------------------------------------------
>
> Key: WODEN-176
> URL: https://issues.apache.org/jira/browse/WODEN-176
> Project: Woden
> Issue Type: Bug
> Reporter: John Kaputin
> Assignee: John Kaputin
> Fix For: M8
>
> Attachments: setParentElement_src_changes.patch, setParentElement_test_changes.patch
>
>
> Since WODEN-40, the Element API uses composition rather than aggregation. Elements have addXXXX methods that instantiate their child elements and set the parent element. It should no longer be necessary nor possible to set the parent element explicitly via the Woden API.
> The setParentElement method should be removed from the NestedElement interface (so it just retains a getParentElement method) and the setParentElement methods implemented in package org.apache.woden.internal.wsdl20 should be given default access (package private) so that they are only available to the addXXXX methods within the WSDL impl classes.
> The calls to setParentElement in the parseXXXX methods of BaseWSDLReader are redundant and should be removed. Some testcases also have redundant calls to setParentElement and those should be removed too. Providing the correct API programming model is used to instantiate objects (via the addXXXX methods), the parent element will always be initialised correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-176) Remove the setParentElement method
from the API
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519442 ]
John Kaputin commented on WODEN-176:
------------------------------------
r565350
Applied fix to remove the method from API, support it in implementation via default access and remove redundant calls in source code and test cases.
> Remove the setParentElement method from the API
> -----------------------------------------------
>
> Key: WODEN-176
> URL: https://issues.apache.org/jira/browse/WODEN-176
> Project: Woden
> Issue Type: Bug
> Reporter: John Kaputin
> Assignee: John Kaputin
> Fix For: M8
>
> Attachments: setParentElement_src_changes.patch, setParentElement_test_changes.patch
>
>
> Since WODEN-40, the Element API uses composition rather than aggregation. Elements have addXXXX methods that instantiate their child elements and set the parent element. It should no longer be necessary nor possible to set the parent element explicitly via the Woden API.
> The setParentElement method should be removed from the NestedElement interface (so it just retains a getParentElement method) and the setParentElement methods implemented in package org.apache.woden.internal.wsdl20 should be given default access (package private) so that they are only available to the addXXXX methods within the WSDL impl classes.
> The calls to setParentElement in the parseXXXX methods of BaseWSDLReader are redundant and should be removed. Some testcases also have redundant calls to setParentElement and those should be removed too. Providing the correct API programming model is used to instantiate objects (via the addXXXX methods), the parent element will always be initialised correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Resolved: (WODEN-176) Remove the setParentElement method
from the API
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin resolved WODEN-176.
--------------------------------
Resolution: Fixed
fixed
> Remove the setParentElement method from the API
> -----------------------------------------------
>
> Key: WODEN-176
> URL: https://issues.apache.org/jira/browse/WODEN-176
> Project: Woden
> Issue Type: Bug
> Reporter: John Kaputin
> Assignee: John Kaputin
> Fix For: M8
>
> Attachments: setParentElement_src_changes.patch, setParentElement_test_changes.patch
>
>
> Since WODEN-40, the Element API uses composition rather than aggregation. Elements have addXXXX methods that instantiate their child elements and set the parent element. It should no longer be necessary nor possible to set the parent element explicitly via the Woden API.
> The setParentElement method should be removed from the NestedElement interface (so it just retains a getParentElement method) and the setParentElement methods implemented in package org.apache.woden.internal.wsdl20 should be given default access (package private) so that they are only available to the addXXXX methods within the WSDL impl classes.
> The calls to setParentElement in the parseXXXX methods of BaseWSDLReader are redundant and should be removed. Some testcases also have redundant calls to setParentElement and those should be removed too. Providing the correct API programming model is used to instantiate objects (via the addXXXX methods), the parent element will always be initialised correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org