[GitHub] [superset] betodealmeida commented on a diff in pull request #23856: fix(tests): Ensure deterministic zip file ordering for CSV uploads

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #23856:
URL: https://github.com/apache/superset/pull/23856#discussion_r1179629913


##########
tests/integration_tests/csv_upload_tests.py:
##########
@@ -556,4 +561,4 @@ def test_import_parquet(mock_event_logger):
 
     with test_db.get_sqla_engine_with_context() as engine:
         data = engine.execute(f"SELECT * from {PARQUET_UPLOAD_TABLE}").fetchall()
-        assert data == [("max", 3), ("bob", 4), ("john", 1), ("paul", 2)]
+        assert data == [("john", 1), ("paul", 2), ("max", 3), ("bob", 4)]

Review Comment:
   A `SELECT` does not guarantee order without an `ORDER BY`; if we don't want to use `sorted()` here we need to add an explicit `ORDER BY` to the query.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org