You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "tibrewalpratik17 (via GitHub)" <gi...@apache.org> on 2023/09/28 21:31:54 UTC
[GitHub] [pinot] tibrewalpratik17 opened a new pull request, #11708: Add more information in RequestContext class
tibrewalpratik17 opened a new pull request, #11708:
URL: https://github.com/apache/pinot/pull/11708
As per discussion in https://github.com/apache/pinot/pull/11437#discussion_r1326698944 adding more information to `RequestContext` class. Most of the fields already existed in `BrokerResponse` so adding more information in `RequestContext` class to use in Event Listener implementation as part of #10606.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on PR #11708:
URL: https://github.com/apache/pinot/pull/11708#issuecomment-1745481612
@walterddr @Jackie-Jiang can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #11708:
URL: https://github.com/apache/pinot/pull/11708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1345317108
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -402,6 +419,136 @@ public void setReduceTimeMillis(long reduceTimeMillis) {
_reduceTimeMillis = reduceTimeMillis;
}
+ @Override
+ public long getNumConsumingSegmentsQueried() {
+ return _numConsumingSegmentsQueried;
+ }
+
+ @Override
+ public void setNumConsumingSegmentsQueried(long numConsumingSegmentsQueried) {
Review Comment:
(nit) I think we can use int instead of long here. May not really matter in the grand scheme of things but off late we have seen a lot of heap usage improvement opportunities from production heap dumps. So just something to consider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1358568153
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -402,6 +419,136 @@ public void setReduceTimeMillis(long reduceTimeMillis) {
_reduceTimeMillis = reduceTimeMillis;
}
+ @Override
+ public long getNumConsumingSegmentsQueried() {
+ return _numConsumingSegmentsQueried;
+ }
+
+ @Override
+ public void setNumConsumingSegmentsQueried(long numConsumingSegmentsQueried) {
Review Comment:
this long is from `BrokerResponse`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11708: Add more information in RequestContext class
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11708:
URL: https://github.com/apache/pinot/pull/11708#issuecomment-1740068915
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11708](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (aff099f) into [master](https://app.codecov.io/gh/apache/pinot/commit/cf8fd93759ebfc521141190196922aa26787c7e1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cf8fd93) will **decrease** coverage by `48.60%`.
> Report is 4 commits behind head on master.
> The diff coverage is `22.58%`.
```diff
@@ Coverage Diff @@
## master #11708 +/- ##
=============================================
- Coverage 63.04% 14.45% -48.60%
+ Complexity 1117 201 -916
=============================================
Files 2342 2342
Lines 125780 125835 +55
Branches 19334 19335 +1
=============================================
- Hits 79301 18185 -61116
- Misses 40828 106108 +65280
+ Partials 5651 1542 -4109
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-17](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.44% <22.58%> (-48.46%)` | :arrow_down: |
| [java-20](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.43% <22.58%> (-48.47%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.45% <22.58%> (-48.60%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.45% <22.58%> (-48.60%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/11708/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.45% <22.58%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `47.12% <100.00%> (+0.72%)` | :arrow_up: |
| [...ava/org/apache/pinot/spi/trace/RequestContext.java](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdHJhY2UvUmVxdWVzdENvbnRleHQuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `18.18% <0.00%> (-0.24%)` | :arrow_down: |
| [...requesthandler/MultiStageBrokerRequestHandler.java](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvTXVsdGlTdGFnZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `18.97% <0.00%> (-0.29%)` | :arrow_down: |
| [.../apache/pinot/spi/trace/DefaultRequestContext.java](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdHJhY2UvRGVmYXVsdFJlcXVlc3RDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [1516 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11708/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on PR #11708:
URL: https://github.com/apache/pinot/pull/11708#issuecomment-1761832999
hey @walterddr can you help in reviewing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1348874021
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java:
##########
@@ -157,6 +161,58 @@ default boolean isSampledRequest() {
void setReduceTimeMillis(long reduceTimeMillis);
+ long getNumConsumingSegmentsQueried();
+
+ void setNumConsumingSegmentsQueried(long numConsumingSegmentsQueried);
+
+ long getNumConsumingSegmentsProcessed();
+
+ void setNumConsumingSegmentsProcessed(long numConsumingSegmentsProcessed);
+
+ long getNumConsumingSegmentsMatched();
+
+ void setNumConsumingSegmentsMatched(long numConsumingSegmentsMatched);
+
+ long getMinConsumingFreshnessTimeMs();
+
+ void setMinConsumingFreshnessTimeMs(long minConsumingFreshnessTimeMs);
+
+ long getNumSegmentsPrunedByBroker();
+
+ void setNumSegmentsPrunedByBroker(long numSegmentsPrunedByBroker);
+
+ long getNumSegmentsPrunedByServer();
+
+ void setNumSegmentsPrunedByServer(long numSegmentsPrunedByServer);
+
+ long getNumSegmentsPrunedInvalid();
+
+ void setNumSegmentsPrunedInvalid(long numSegmentsPrunedInvalid);
+
+ long getNumSegmentsPrunedByLimit();
+
+ void setNumSegmentsPrunedByLimit(long numSegmentsPrunedByLimit);
+
+ long getNumSegmentsPrunedByValue();
+
+ void setNumSegmentsPrunedByValue(long numSegmentsPrunedByValue);
+
+ long getExplainPlanNumEmptyFilterSegments();
+
+ void setExplainPlanNumEmptyFilterSegments(long explainPlanNumEmptyFilterSegments);
+
+ long getExplainPlanNumMatchAllFilterSegments();
+
+ void setExplainPlanNumMatchAllFilterSegments(long explainPlanNumMatchAllFilterSegments);
+
+ Map<String, String> getTraceInfo();
+
+ void setTraceInfo(Map<String, String> traceInfo);
Review Comment:
Yes but we would still want to keep the trace-info in the event so that we can persist it in Kafka / Hive and refer it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #11708: Add more information in RequestContext class
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #11708:
URL: https://github.com/apache/pinot/pull/11708#issuecomment-1740144719
@siddharthteotia @jackjlli Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1348824037
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java:
##########
@@ -91,7 +95,7 @@ default boolean isSampledRequest() {
String getQuery();
- String getTableName();
+ List<String> getTableNames();
Review Comment:
should keep getTableName and add a getTableNames
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java:
##########
@@ -157,6 +161,58 @@ default boolean isSampledRequest() {
void setReduceTimeMillis(long reduceTimeMillis);
+ long getNumConsumingSegmentsQueried();
+
+ void setNumConsumingSegmentsQueried(long numConsumingSegmentsQueried);
+
+ long getNumConsumingSegmentsProcessed();
+
+ void setNumConsumingSegmentsProcessed(long numConsumingSegmentsProcessed);
+
+ long getNumConsumingSegmentsMatched();
+
+ void setNumConsumingSegmentsMatched(long numConsumingSegmentsMatched);
+
+ long getMinConsumingFreshnessTimeMs();
+
+ void setMinConsumingFreshnessTimeMs(long minConsumingFreshnessTimeMs);
+
+ long getNumSegmentsPrunedByBroker();
+
+ void setNumSegmentsPrunedByBroker(long numSegmentsPrunedByBroker);
+
+ long getNumSegmentsPrunedByServer();
+
+ void setNumSegmentsPrunedByServer(long numSegmentsPrunedByServer);
+
+ long getNumSegmentsPrunedInvalid();
+
+ void setNumSegmentsPrunedInvalid(long numSegmentsPrunedInvalid);
+
+ long getNumSegmentsPrunedByLimit();
+
+ void setNumSegmentsPrunedByLimit(long numSegmentsPrunedByLimit);
+
+ long getNumSegmentsPrunedByValue();
+
+ void setNumSegmentsPrunedByValue(long numSegmentsPrunedByValue);
+
+ long getExplainPlanNumEmptyFilterSegments();
+
+ void setExplainPlanNumEmptyFilterSegments(long explainPlanNumEmptyFilterSegments);
+
+ long getExplainPlanNumMatchAllFilterSegments();
+
+ void setExplainPlanNumMatchAllFilterSegments(long explainPlanNumMatchAllFilterSegments);
+
+ Map<String, String> getTraceInfo();
+
+ void setTraceInfo(Map<String, String> traceInfo);
Review Comment:
i am not sure default creating these for tracing is a good idea. normally we dont enable tracing for production use case, so for those that were manually enabled, those must've been monitored and thus renders it less useful to keep the event listener (e.g. there's a human tracking it already)
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/RequestContext.java:
##########
@@ -63,7 +67,7 @@ default boolean isSampledRequest() {
void setQuery(String pql);
- void setTableName(String tableName);
+ void setTableNames(List<String> tableNames);
Review Comment:
should not change the function signature in this API directly IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1345337649
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -63,6 +67,19 @@ public class DefaultRequestContext implements RequestScope {
private FanoutType _fanoutType;
private int _numUnavailableSegments;
+ private long _numConsumingSegmentsQueried;
Review Comment:
Not directly related to this PR -- I don't think we track RequestCompilationTime in BrokerResponse or RequestContext statistics. It is emitted as a metric from the code.
But I guess we should. Within LinkedIn we have always had requests that can take tens to hundreds of ms to compile a query. Will become more relevant in the context of multi stage engine imo.
Need not necessarily do as part of this PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add more information in RequestContext class [pinot]
Posted by "tibrewalpratik17 (via GitHub)" <gi...@apache.org>.
tibrewalpratik17 commented on code in PR #11708:
URL: https://github.com/apache/pinot/pull/11708#discussion_r1346452689
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/DefaultRequestContext.java:
##########
@@ -63,6 +67,19 @@ public class DefaultRequestContext implements RequestScope {
private FanoutType _fanoutType;
private int _numUnavailableSegments;
+ private long _numConsumingSegmentsQueried;
Review Comment:
Yes the plan is to add more metrics as need be. Thanks for bring this up - `RequestCompilationTime`. I am planning to add `stageStats` as well for multistage queries but that needs some discussion. Will take adding `RequestCompilationTime` in a follow-up PR. This PR tries to get alignment between brokerResponse and RequestContext class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org