[GitHub] [accumulo] hkeebler opened a new pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts

[GitBox <gi...@apache.org>]

hkeebler opened a new pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts
URL: https://github.com/apache/accumulo/pull/1330
 
 
   Uses property overrides instead of command line options and includes GC safemode option.
   
   This includes:
   - properties for <servertype>.bind.address added to Property.java with defaults
   - property for GC safemode
   - deprecation of safemode command line option
   - removal of --address command line option (deprecating would have made for some ugly code - could be revisited if desired)
   - addition of a GC safemode IT test (could not find one already out there) .   Could be improved - copied from GarbargeCollectorIT.  Trying to find a way to override a property (not from the command line) was difficult.
   
   This did not address merging the host and port properties together or discerning bind addresses from advertised addresses.  I'm not sure what the difference really is.  Monitor was the only server that used an "adveristedHost" which was the bind address.
   Note that the override properties processing as of now does not take into account boolean type properties with no value assigned.  Maybe a new ticket as well as documentation updates.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services