[GitHub] [arrow] wesm commented on a diff in pull request #13753: ARROW-17259: [C++] Do not use shared_ptr with kernel function signatures, do less copying of shared_ptrs

[GitBox <gi...@apache.org>]

wesm commented on code in PR #13753:
URL: https://github.com/apache/arrow/pull/13753#discussion_r933668310


##########
cpp/src/arrow/type.h:
##########
@@ -2120,35 +2108,4 @@ ARROW_EXPORT
 std::string ToString(TimeUnit::type unit);
 
 }  // namespace internal
-
-// Helpers to get instances of data types based on general categories
-
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& SignedIntTypes();
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& UnsignedIntTypes();
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& IntTypes();
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& FloatingPointTypes();
-// Number types without boolean
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& NumericTypes();
-// Binary and string-like types (except fixed-size binary)
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& BaseBinaryTypes();
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& BinaryTypes();
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& StringTypes();
-// Temporal types including time and timestamps for each unit
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& TemporalTypes();
-// Interval types
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& IntervalTypes();
-// Integer, floating point, base binary, and temporal
-ARROW_EXPORT
-const std::vector<std::shared_ptr<DataType>>& PrimitiveTypes();
-

Review Comment:
   There wasn't really a good reason for these functions to be here -- they probably even should be in an internal namespace in arrow::compute



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org