[GitHub] [pinot] walterddr commented on pull request #11330: [multistage] Fixing pinot client resolve table name

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on PR #11330:
URL: https://github.com/apache/pinot/pull/11330#issuecomment-1720273025

   Discussed with @Jackie-Jiang we should probably deprecate the BrokerSelect API 
   ```
   String selectBroker(String... tableName)
   ```
   this API only make sense during v1 query where it is guarantee to only hint 1 table; and it is not a clear API for multi-stage engine, instead we should add
   ```
   String selectBroker(String sql);
   ```
   
   and encapsulate the current logic to parse table when SQL is a v1 query (for legacy compatibility) and use controller endpoint to select broker instead of a local broker cache in ControllerBaseBrokerSelector.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org