You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/05 06:07:18 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #7017: [refactor] set forward_to_master true by default
yangzhg opened a new pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017
## Proposed changes
1. set forward_to_master true by default
2. `show routine load task` always forward to master
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [x] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743415853
##########
File path: docs/zh-CN/administrator-guide/variables.md
##########
@@ -192,7 +192,7 @@ SELECT /*+ SET_VAR(query_timeout = 1, enable_partition_cache=true) */ sleep(3);
* `forward_to_master`
- 用户设置是否将一些命令转发到 Master FE 节点执行。默认为 false，即不转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
+ 用户设置是否将一些命令转发到 Master FE 节点执行。默认为 `true`，即不转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
Review comment:
```suggestion
用户设置是否将一些show 类命令转发到 Master FE 节点执行。默认为 `true`，即转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#issuecomment-961926799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743673756
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -426,7 +426,10 @@ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws
// 1. Find if the given BE id has available slots
if (previoudBeId != -1L) {
int idleTaskNum = 0;
- if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+ if (beIdToMaxConcurrentTasks.containsKey(previoudBeId)) {
+ idleTaskNum = 0;
+ LOG.warn("backend:" + previoudBeId + " not found, cannot get idleTaskNum.");
Review comment:
No need to print warn log here because this is not a root cause.
The root cause is because BE is down. And `beIdToMaxConcurrentTasks` only contains alive Backends.
So here we can just check if `beIdToMaxConcurrentTasks.containsKey(previoudBeId)`
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -426,7 +426,10 @@ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws
// 1. Find if the given BE id has available slots
if (previoudBeId != -1L) {
int idleTaskNum = 0;
- if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+ if (beIdToMaxConcurrentTasks.containsKey(previoudBeId)) {
+ idleTaskNum = 0;
+ LOG.warn("backend:" + previoudBeId + " not found, cannot get idleTaskNum.");
Review comment:
And BE crash because of this #6716. Need further debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7017: [refactor] set forward_to_master true by default
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743411745
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -314,7 +314,7 @@
private boolean enableJoinReorderBasedCost = false;
@VariableMgr.VarAttr(name = FORWARD_TO_MASTER)
- public boolean forwardToMaster = false;
+ public boolean forwardToMaster = true;
Review comment:
default is true?? The query will also forward to master???
##########
File path: docs/zh-CN/administrator-guide/variables.md
##########
@@ -192,7 +192,7 @@ SELECT /*+ SET_VAR(query_timeout = 1, enable_partition_cache=true) */ sleep(3);
* `forward_to_master`
- 用户设置是否将一些命令转发到 Master FE 节点执行。默认为 false，即不转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
+ 用户设置是否将一些命令转发到 Master FE 节点执行。默认为 `true`，即不转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
Review comment:
```suggestion
用户设置是否将一些show 类命令转发到 Master FE 节点执行。默认为 `true`，即转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#issuecomment-961926799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743673756
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -426,7 +426,10 @@ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws
// 1. Find if the given BE id has available slots
if (previoudBeId != -1L) {
int idleTaskNum = 0;
- if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+ if (beIdToMaxConcurrentTasks.containsKey(previoudBeId)) {
+ idleTaskNum = 0;
+ LOG.warn("backend:" + previoudBeId + " not found, cannot get idleTaskNum.");
Review comment:
No need to print warn log here because this is not a root cause.
The root cause is because BE is down. And `beIdToMaxConcurrentTasks` only contains alive Backends.
So here we can just check if `beIdToMaxConcurrentTasks.containsKey(previoudBeId)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743673756
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -426,7 +426,10 @@ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws
// 1. Find if the given BE id has available slots
if (previoudBeId != -1L) {
int idleTaskNum = 0;
- if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+ if (beIdToMaxConcurrentTasks.containsKey(previoudBeId)) {
+ idleTaskNum = 0;
+ LOG.warn("backend:" + previoudBeId + " not found, cannot get idleTaskNum.");
Review comment:
No need to print warn log here because this is not a root cause.
The root cause is because BE is down. And `beIdToMaxConcurrentTasks` only contains alive Backends.
So here we can just check if `beIdToMaxConcurrentTasks.containsKey(previoudBeId)`
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -426,7 +426,10 @@ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws
// 1. Find if the given BE id has available slots
if (previoudBeId != -1L) {
int idleTaskNum = 0;
- if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+ if (beIdToMaxConcurrentTasks.containsKey(previoudBeId)) {
+ idleTaskNum = 0;
+ LOG.warn("backend:" + previoudBeId + " not found, cannot get idleTaskNum.");
Review comment:
And BE crash because of this #6716. Need further debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743415451
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -314,7 +314,7 @@
private boolean enableJoinReorderBasedCost = false;
@VariableMgr.VarAttr(name = FORWARD_TO_MASTER)
- public boolean forwardToMaster = false;
+ public boolean forwardToMaster = true;
Review comment:
Only effect the following stmts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7017: [refactor] set forward_to_master true by default
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743411745
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -314,7 +314,7 @@
private boolean enableJoinReorderBasedCost = false;
@VariableMgr.VarAttr(name = FORWARD_TO_MASTER)
- public boolean forwardToMaster = false;
+ public boolean forwardToMaster = true;
Review comment:
default is true?? The query will also forward to master???
##########
File path: docs/zh-CN/administrator-guide/variables.md
##########
@@ -192,7 +192,7 @@ SELECT /*+ SET_VAR(query_timeout = 1, enable_partition_cache=true) */ sleep(3);
* `forward_to_master`
- 用户设置是否将一些命令转发到 Master FE 节点执行。默认为 false，即不转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
+ 用户设置是否将一些命令转发到 Master FE 节点执行。默认为 `true`，即不转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
Review comment:
```suggestion
用户设置是否将一些show 类命令转发到 Master FE 节点执行。默认为 `true`，即转发。Doris 中存在多个 FE 节点，其中一个为 Master 节点。通常用户可以连接任意 FE 节点进行全功能操作。但部分信息查看指令，只有从 Master FE 节点才能获取详细信息。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743415451
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -314,7 +314,7 @@
private boolean enableJoinReorderBasedCost = false;
@VariableMgr.VarAttr(name = FORWARD_TO_MASTER)
- public boolean forwardToMaster = false;
+ public boolean forwardToMaster = true;
Review comment:
Only effect the following stmts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7017: [refactor] set forward_to_master true by default
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743411745
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -314,7 +314,7 @@
private boolean enableJoinReorderBasedCost = false;
@VariableMgr.VarAttr(name = FORWARD_TO_MASTER)
- public boolean forwardToMaster = false;
+ public boolean forwardToMaster = true;
Review comment:
default is true?? The query will also forward to master???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743674558
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -426,7 +426,10 @@ public long getAvailableBeForTask(long previoudBeId, String clusterName) throws
// 1. Find if the given BE id has available slots
if (previoudBeId != -1L) {
int idleTaskNum = 0;
- if (beIdToConcurrentTasks.containsKey(previoudBeId)) {
+ if (beIdToMaxConcurrentTasks.containsKey(previoudBeId)) {
+ idleTaskNum = 0;
+ LOG.warn("backend:" + previoudBeId + " not found, cannot get idleTaskNum.");
Review comment:
And BE crash because of this #6716. Need further debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #7017: [refactor] set `forward_to_master` true by default
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #7017:
URL: https://github.com/apache/incubator-doris/pull/7017#discussion_r743415451
##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
##########
@@ -314,7 +314,7 @@
private boolean enableJoinReorderBasedCost = false;
@VariableMgr.VarAttr(name = FORWARD_TO_MASTER)
- public boolean forwardToMaster = false;
+ public boolean forwardToMaster = true;
Review comment:
Only effect the following stmts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org