[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1521: [CALCITE-3429] Support MAP type for JavaToSqlTypeConversionRules

[GitBox <gi...@apache.org>]

yanlin-Lynn commented on a change in pull request #1521: [CALCITE-3429] Support MAP type for JavaToSqlTypeConversionRules
URL: https://github.com/apache/calcite/pull/1521#discussion_r336875564
 
 

 ##########
 File path: geode/src/test/java/org/apache/calcite/adapter/geode/rel/GeodeBookstoreTest.java
 ##########
 @@ -379,10 +385,36 @@ public void testSelectWithNestedPdx2() {
     calciteAssert()
         .query("select primaryAddress from geode.BookCustomer limit 2")
         .returnsCount(2)
-        .returns("primaryAddress=PDX[addressLine1,addressLine2,addressLine3,city,state,"
-            + "postalCode,country,phoneNumber,addressTag]\n"
-            + "primaryAddress=PDX[addressLine1,addressLine2,addressLine3,city,state,postalCode,"
-            + "country,phoneNumber,addressTag]\n")
+        .returns(new Consumer<ResultSet>() {
 
 Review comment:
   I update this case to make it pass.
   But I'm not quite familiar with the logic, hopes someone more familiar with it can review this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services