[GitHub] [incubator-iceberg] Fokko commented on a change in pull request #297: Bump Apache Avro to 1.9.x

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #297: Bump Apache Avro to 1.9.x
URL: https://github.com/apache/incubator-iceberg/pull/297#discussion_r356825693
 
 

 ##########
 File path: spark/src/test/java/org/apache/iceberg/spark/source/TestDataSourceOptions.java
 ##########
 @@ -196,6 +196,6 @@ public void testSplitOptionsOverridesTableProperties() throws IOException {
         .option("split-size", String.valueOf(562L)) // 562 bytes is the size of SimpleRecord(1,"a")
         .load(tableLocation);
 
-    Assert.assertEquals("Spark partitions should match", 2, resultDf.javaRDD().getNumPartitions());
+    Assert.assertEquals("Spark partitions should match", 4, resultDf.javaRDD().getNumPartitions());
 
 Review comment:
   I've also mentioned this on the devlist, the parquet file size grew a bit bigger. Probably the column indexes, CRC checksum, removing the statistics from the page headers and maybe other changes that impact file size.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org