You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 06:45:51 UTC
[GitHub] [arrow] xhochy opened a new pull request #7286: ARROW-8962: [C++] Add explicit implementation for junk values
xhochy opened a new pull request #7286:
URL: https://github.com/apache/arrow/pull/7286
When linking the tests with `clang-4.0`, I get
```
Undefined symbols for architecture x86_64:
"arrow::internal::(anonymous namespace)::StringToFloatConverterImpl::main_junk_value_", referenced from:
arrow::internal::StringToFloat(char const*, unsigned long, float*) in libarrow.a(value_parsing.cc.o)
arrow::internal::StringToFloat(char const*, unsigned long, double*) in libarrow.a(value_parsing.cc.o)
"arrow::internal::(anonymous namespace)::StringToFloatConverterImpl::fallback_junk_value_", referenced from:
arrow::internal::StringToFloat(char const*, unsigned long, float*) in libarrow.a(value_parsing.cc.o)
arrow::internal::StringToFloat(char const*, unsigned long, double*) in libarrow.a(value_parsing.cc.o)
ld: symbol(s) not found for architecture x86_64
```
These older clang versions need an explicit implementation definition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7286: ARROW-8962: [C++] Add explicit implementation for junk values
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7286:
URL: https://github.com/apache/arrow/pull/7286#issuecomment-634463719
https://issues.apache.org/jira/browse/ARROW-8962
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques closed pull request #7286: ARROW-8962: [C++] Add explicit implementation for junk values
Posted by GitBox <gi...@apache.org>.
fsaintjacques closed pull request #7286:
URL: https://github.com/apache/arrow/pull/7286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org