You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "slbotbm (via GitHub)" <gi...@apache.org> on 2026/02/18 13:35:05 UTC
[PR] change local dev environment to use uv [iggy]
slbotbm opened a new pull request, #2767:
URL: https://github.com/apache/iggy/pull/2767
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2766
## Rationale
<!--
Why is this change needed? If the issue explains it well, a one-liner is fine.
-->
## What changed?
<!--
2-4 sentences. Problem first (before), then solution (after).
GOOD:
"Messages were unavailable when background message_saver committed the
journal and started async disk I/O before completion. Polling during
this window found neither journal nor disk data.
The fix freezes journal batches in the in-flight buffer before async persist."
GOOD:
"When many small messages accumulate in the journal, the flush passes
thousands of IO vectors to writev(), exceeding IOV_MAX (1024 on Linux)."
BAD:
- Walls of text
- "This PR adds..." (we can see the diff)
-->
Added uv.lock, and changed local docker files to utilize uv. Updated foreign/python/README.md.
TODO: Update CI scripts.
## Local Execution
- Passed
- Pre-commit hooks ran
<!--
You must run your code locally before submitting.
"Relying on CI" is not acceptable - PRs from authors who haven't run the code will be closed.
Did you have `prek` installed? It runs automatically on commit and covers all project languages. See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md).
-->
## AI Usage
No usage
<!--
If AI tools were used, please answer:
1. Which tools? (e.g., GitHub Copilot, Claude, ChatGPT)
2. Scope of usage? (e.g., autocomplete, generated functions, entire implementation)
3. How did you verify the generated code works correctly?
4. Can you explain every line of the code if asked?
If no AI tools were used, write "None" or delete this section.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(python): replace pip with uv [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2767:
URL: https://github.com/apache/iggy/pull/2767#issuecomment-3921638408
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2767?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 68.34%. Comparing base ([`f8566c5`](https://app.codecov.io/gh/apache/iggy/commit/f8566c546e561aaf94625a855ae93f210067ab3a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`47b6e63`](https://app.codecov.io/gh/apache/iggy/commit/47b6e637c395dcda65c298458c463e7018015e05?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2767 +/- ##
============================================
+ Coverage 68.31% 68.34% +0.02%
Complexity 656 656
============================================
Files 741 741
Lines 62165 62165
Branches 58578 58578
============================================
+ Hits 42468 42484 +16
+ Misses 17586 17571 -15
+ Partials 2111 2110 -1
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2767/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/iggy/pull/2767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.19% <ø> (ø)` | |
| [rust](https://app.codecov.io/gh/apache/iggy/pull/2767/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.40% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 8 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2767/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(python): replace pip with uv [iggy]
Posted by "slbotbm (via GitHub)" <gi...@apache.org>.
slbotbm commented on code in PR #2767:
URL: https://github.com/apache/iggy/pull/2767#discussion_r2822405954
##########
foreign/python/Dockerfile.test:
##########
@@ -16,7 +16,7 @@
# under the License.
# Multi-stage build for Python SDK testing
-FROM python:3.11-slim AS base
+FROM python:3.10-slim AS base
Review Comment:
We're defining 3.10 in the pyproject.toml, so I downgraded this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(python): replace pip with uv [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2767:
URL: https://github.com/apache/iggy/pull/2767#discussion_r2824318065
##########
foreign/python/Dockerfile.test:
##########
@@ -16,7 +16,7 @@
# under the License.
# Multi-stage build for Python SDK testing
-FROM python:3.11-slim AS base
+FROM python:3.10-slim AS base
Review Comment:
Can you create an issue to add verification to CI and precommit hooks to keep it synced? Similar to `sync-rust-version.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(python): replace pip with uv [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2767:
URL: https://github.com/apache/iggy/pull/2767#discussion_r2822403491
##########
foreign/python/Dockerfile.test:
##########
@@ -16,7 +16,7 @@
# under the License.
# Multi-stage build for Python SDK testing
-FROM python:3.11-slim AS base
+FROM python:3.10-slim AS base
Review Comment:
what's the reason for this downgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(python): replace pip with uv [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #2767:
URL: https://github.com/apache/iggy/pull/2767#discussion_r2824318065
##########
foreign/python/Dockerfile.test:
##########
@@ -16,7 +16,7 @@
# under the License.
# Multi-stage build for Python SDK testing
-FROM python:3.11-slim AS base
+FROM python:3.10-slim AS base
Review Comment:
Can you create an issue to add verification to CI and precommit hooks to keep it synced? similar to `sync-rust-version.sh`. Actually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(python): replace pip with uv [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski merged PR #2767:
URL: https://github.com/apache/iggy/pull/2767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(python): replace pip with uv [iggy]
Posted by "slbotbm (via GitHub)" <gi...@apache.org>.
slbotbm commented on PR #2767:
URL: https://github.com/apache/iggy/pull/2767#issuecomment-3921786338
I've changed foreign/python, examples/python, bdd/python to utilize uv instead of pip. The CI also uses uv now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org