You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/11 18:18:57 UTC
[GitHub] [calcite] julianhyde commented on a change in pull request #2347: CALCITE-4494 Improve planning performance with RelSubset check for Rel presence
julianhyde commented on a change in pull request #2347:
URL: https://github.com/apache/calcite/pull/2347#discussion_r574724664
##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/RelSubset.java
##########
@@ -433,6 +433,13 @@ RelNode buildCheapestPlan(VolcanoPlanner planner) {
return list;
}
+ /**
+ * Checks whether the rel is a part of the current subset.
+ */
+ public boolean containsRel(RelNode node) {
Review comment:
change the name to `contains` rather than `containsRel`?
Change the javadoc to 'Returns whether' rather than 'Checks whether'. (Often methods that 'check' return void, and throw if the condition is violated.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org