You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by warmana <gi...@git.apache.org> on 2016/10/18 12:14:03 UTC
[GitHub] couchdb-documentation pull request #83: Describe selector objects as part of...
GitHub user warmana opened a pull request:
https://github.com/apache/couchdb-documentation/pull/83
Describe selector objects as part of a replication document.
Add material explaining what a selector object is, in the context of a replication document.
Point out that it is one of three options for controlling replication.
Point out that using a selector object is preferable to using a filter function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/warmana/couchdb-documentation-fork describeSelectorInReplicationDocument
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-documentation/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit c92f59ceee622ef64a658f0eb6c7f643539aff76
Author: Adrian Warman <wa...@gmail.com>
Date: 2016-10-18T12:09:53Z
Add material describing selector objects as part of a replication document.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-documentation/pull/83
Look great, @warmana
Merged.
Thank you again, for your contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-documentation/pull/83
Looks good @warmana . Thank you. One minor thing is some lines are two long and the make lint check target for documentation is failing (if you clink on the red X it shows some of the failing lines).
Here is one example line:
```
python ext/linter.py src/
/home/travis/build/apache/couchdb-documentation/src/json-structure.rst
line 246 : too long (86 > 80) line
+--------------------------------+---------------------------------------------------+
line 247 : too long (86 > 80) line
| Field | Description |
```
Also I see this for the main check:
```
/Users/nvatama/asf/couchdb/src/docs/src/replication/replicator.rst
line 437 : too many empty lines
line 437 : no empty last lines please
```
Would it be possible to make the lines shorter or it is part of the table, it would completely break the layout? If it is too hard, we can look at perhaps disabling the warning for that file. Let me know if you need help, I can try to do some of these cleanups if setting up the doc compilation chain is too tricky.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...
Posted by warmana <gi...@git.apache.org>.
Github user warmana commented on the issue:
https://github.com/apache/couchdb-documentation/pull/83
Aha, apologies for both of those. I can and will fix them...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request #83: Describe selector objects as part of...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-documentation/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---