You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 17:22:00 UTC

[GitHub] [arrow] ViniciusSouzaRoque commented on a diff in pull request #12716: ARROW-16031: [C++][Gandiva] Fix Soundex errors generate

ViniciusSouzaRoque commented on code in PR #12716:
URL: https://github.com/apache/arrow/pull/12716#discussion_r848682428


##########
cpp/src/gandiva/precompiled/string_ops.cc:
##########
@@ -2814,46 +2845,51 @@ const char* soundex_utf8(gdv_int64 ctx, const char* in, gdv_int32 in_len,
     return "";
   }
 
+  char* in_clean;
+  int len_clean;
+
+  // Removing numbers, spaces and special characters, and put upper all letters
+  in_clean = reinterpret_cast<char*>(gdv_fn_context_arena_malloc(ctx, in_len));
+  memcpy(in_clean, in, in_len);

Review Comment:
   this has removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org