You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by li xu <le...@gmail.com> on 2011/08/22 23:34:52 UTC
Review Request: EE sample gadget doesn't work out of box if deployed with
context other than root or deployed on port other than 8080
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/
-----------------------------------------------------------
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Summary
-------
This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080
we added two tokens at sample db: canonicaldb.json
%contextroot%
%origin%
it's resolved by JsonDBOpensocialService.java based on injected hostProvider
This is a generic change... any other opensocial object could use the same token in sample json db.
Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml
"eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
fixed related junit tests.
Thanks to Ryan's help on this!
Diffs
-----
/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372
/trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372
/trunk/content/sampledata/canonicaldb.json 1160372
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372
Diff: https://reviews.apache.org/r/1616/diff
Testing
-------
Passed JUnit tests.
Tested with /embeddedexperiences/index.html
Thanks,
li
Re: Review Request: EE sample gadget doesn't work out of box if deployed
with context other than root or deployed on port other than 8080
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/#review1598
-----------------------------------------------------------
Overall this looks good! Thanks for doing this. Only small nits on extra white spaces and such. One thing that will help you out with these type of things if you're using Eclipse is to import the formatting and code style templates for Shindig into your workspace. There's a set for Java and Javascript. You can find them shindig-project/etc/eclipse.
/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
<https://reviews.apache.org/r/1616/#comment3605>
Remove the extra spaces here
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/1616/#comment3606>
Remove extra spaces here
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/1616/#comment3607>
Remove extra spaces here
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/1616/#comment3608>
Remove extra spaces here
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/1616/#comment3609>
Remove the line break here
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/1616/#comment3610>
Some formatting in general here. Usually there are now spaces after/before ( and ). Also you want to put spaces before and after the else. The Eclipse formatting/code style templates will really help you out with this type of stuff.
- Ryan
On 2011-08-22 21:34:52, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1616/
> -----------------------------------------------------------
>
> (Updated 2011-08-22 21:34:52)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080
>
> we added two tokens at sample db: canonicaldb.json
> %contextroot%
> %origin%
> it's resolved by JsonDBOpensocialService.java based on injected hostProvider
> This is a generic change... any other opensocial object could use the same token in sample json db.
>
> Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml
> "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
> fixed related junit tests.
>
> Thanks to Ryan's help on this!
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372
> /trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372
> /trunk/content/sampledata/canonicaldb.json 1160372
> /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372
>
> Diff: https://reviews.apache.org/r/1616/diff
>
>
> Testing
> -------
>
> Passed JUnit tests.
> Tested with /embeddedexperiences/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: EE sample gadget doesn't work out of box if deployed
with context other than root or deployed on port other than 8080
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/#review1620
-----------------------------------------------------------
Ship it!
Committed revision 1161323. Please close the JIRA as well. Thanks.
- Ryan
On 2011-08-24 20:14:29, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1616/
> -----------------------------------------------------------
>
> (Updated 2011-08-24 20:14:29)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080
>
> we added two tokens at sample db: canonicaldb.json
> %contextroot%
> %origin%
> it's resolved by JsonDBOpensocialService.java based on injected hostProvider
> This is a generic change... any other opensocial object could use the same token in sample json db.
>
> Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml
> "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
> fixed related junit tests.
>
> Thanks to Ryan's help on this!
>
>
> This addresses bug shindig-1592.
> https://issues.apache.org/jira/browse/shindig-1592
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372
> /trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372
> /trunk/content/sampledata/canonicaldb.json 1160372
> /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372
>
> Diff: https://reviews.apache.org/r/1616/diff
>
>
> Testing
> -------
>
> Passed JUnit tests.
> Tested with /embeddedexperiences/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: EE sample gadget doesn't work out of box if deployed
with context other than root or deployed on port other than 8080
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/
-----------------------------------------------------------
(Updated 2011-08-24 20:14:29.491196)
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Changes
-------
Thanks for catching this, Ryan.
is all the procedure documented somewhere? seems like I missed a few...
Summary
-------
This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080
we added two tokens at sample db: canonicaldb.json
%contextroot%
%origin%
it's resolved by JsonDBOpensocialService.java based on injected hostProvider
This is a generic change... any other opensocial object could use the same token in sample json db.
Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml
"eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
fixed related junit tests.
Thanks to Ryan's help on this!
This addresses bug shindig-1592.
https://issues.apache.org/jira/browse/shindig-1592
Diffs
-----
/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372
/trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372
/trunk/content/sampledata/canonicaldb.json 1160372
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372
Diff: https://reviews.apache.org/r/1616/diff
Testing
-------
Passed JUnit tests.
Tested with /embeddedexperiences/index.html
Thanks,
li
Re: Review Request: EE sample gadget doesn't work out of box if deployed
with context other than root or deployed on port other than 8080
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/#review1603
-----------------------------------------------------------
One more thing Li, please create a JIRA and attach the patch to it. Then put the link to it in the Bugs section of the review. (You should be able to just put SHINDIG-xxxx and it will link the review and the JIRA.)
- Ryan
On 2011-08-23 21:47:22, li xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1616/
> -----------------------------------------------------------
>
> (Updated 2011-08-23 21:47:22)
>
>
> Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
>
>
> Summary
> -------
>
> This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080
>
> we added two tokens at sample db: canonicaldb.json
> %contextroot%
> %origin%
> it's resolved by JsonDBOpensocialService.java based on injected hostProvider
> This is a generic change... any other opensocial object could use the same token in sample json db.
>
> Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml
> "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
> fixed related junit tests.
>
> Thanks to Ryan's help on this!
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372
> /trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372
> /trunk/content/sampledata/canonicaldb.json 1160372
> /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372
> /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372
>
> Diff: https://reviews.apache.org/r/1616/diff
>
>
> Testing
> -------
>
> Passed JUnit tests.
> Tested with /embeddedexperiences/index.html
>
>
> Thanks,
>
> li
>
>
Re: Review Request: EE sample gadget doesn't work out of box if deployed
with context other than root or deployed on port other than 8080
Posted by li xu <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1616/
-----------------------------------------------------------
(Updated 2011-08-23 21:47:22.758827)
Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.
Changes
-------
cleaned up spaces
Summary
-------
This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080
we added two tokens at sample db: canonicaldb.json
%contextroot%
%origin%
it's resolved by JsonDBOpensocialService.java based on injected hostProvider
This is a generic change... any other opensocial object could use the same token in sample json db.
Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml
"eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
fixed related junit tests.
Thanks to Ryan's help on this!
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372
/trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372
/trunk/content/sampledata/canonicaldb.json 1160372
/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372
/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372
Diff: https://reviews.apache.org/r/1616/diff
Testing
-------
Passed JUnit tests.
Tested with /embeddedexperiences/index.html
Thanks,
li