You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/04/27 14:54:32 UTC
Review Request 58800: Changes to events format
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58800/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-20869
https://issues.apache.org/jira/browse/AMBARI-20869
Repository: ambari
Description
-------
Changes we discussed with Myroslav Papyrkovskyy to format data in more suitable
for server way.
* use cluster id instead of name
* remove some dictionary keys in events to make handing them simpler
* don't use component name as key in topology dictionary to be ready for multiInstances work.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ClusterCache.py d5e724c
ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 03e9645
ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 70cd82a
ambari-agent/src/main/python/ambari_agent/Constants.py 5ea916c
ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 6b68f27
ambari-agent/src/main/python/ambari_agent/Utils.py 456b2b3
ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 7ea0646
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/components_status_report.json c1ce406
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/configurations_update.json 41cef61
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/execution_commands.json 1eeeb7c
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json 8ccd8e8
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_update.json 96b929b
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_request.json 64077b3
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_response.json f744410
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_update.json 291249c
Diff: https://reviews.apache.org/r/58800/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 58800: Changes to events format
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58800/#review173220
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On April 27, 2017, 2:54 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58800/
> -----------------------------------------------------------
>
> (Updated April 27, 2017, 2:54 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-20869
> https://issues.apache.org/jira/browse/AMBARI-20869
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Changes we discussed with Myroslav Papyrkovskyy to format data in more suitable
> for server way.
>
> * use cluster id instead of name
> * remove some dictionary keys in events to make handing them simpler
> * don't use component name as key in topology dictionary to be ready for multiInstances work.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/ClusterCache.py d5e724c
> ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py 03e9645
> ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 70cd82a
> ambari-agent/src/main/python/ambari_agent/Constants.py 5ea916c
> ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 6b68f27
> ambari-agent/src/main/python/ambari_agent/Utils.py 456b2b3
> ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 7ea0646
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/components_status_report.json c1ce406
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/configurations_update.json 41cef61
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/execution_commands.json 1eeeb7c
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_after_registration.json 8ccd8e8
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/metadata_update.json 96b929b
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_request.json 64077b3
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/registration_response.json f744410
> ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/topology_update.json 291249c
>
>
> Diff: https://reviews.apache.org/r/58800/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>