You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "Rob Vesse (JIRA)" <ji...@apache.org> on 2012/05/02 18:00:50 UTC
[jira] [Commented] (JENA-240) If the remote SPARQL Service endpoint
does not respond the query hangs, Adding timeout to the Service should fix
the problem
[ https://issues.apache.org/jira/browse/JENA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266658#comment-13266658 ]
Rob Vesse commented on JENA-240:
--------------------------------
Hi Claude, thanks for your contribution, I just have a couple of questions for you:
How was this patch generated?
It appears to replace almost the entire class some bits of which appear to have minimal changes which suggests a mismatch in your SVN EOL settings, this is an issue I've run into in the past when developing patches on Windows - see http://mail-archives.apache.org/mod_mbox/incubator-jena-dev/201111.mbox/%3CC0B6979A3CA668458B697E4EA907CA9401825F@CFWEX01.americas.cray.com%3E for ways to solve this. If you are able to regenerate the patch so that it contains only the actual changes that would be preferred as it is much easier to review and integrate if the patch only contains your changes.
Also have you considered writing any tests for this?
It should be fairly trivial to write a test to a known non-existent server (maybe localhost on some random port) which demonstrates that timeouts do apply as expected after these changes. While lack of tests is not a barrier to integration it's another things that makes it easier to review and integrate
> If the remote SPARQL Service endpoint does not respond the query hangs, Adding timeout to the Service should fix the problem
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JENA-240
> URL: https://issues.apache.org/jira/browse/JENA-240
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Affects Versions: ARQ 2.9.0, ARQ 2.9.1
> Reporter: Claude Warren
> Assignee: Rob Vesse
> Attachments: patch.txt
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When creating the HttpQuery object the com.hp.hpl.jena.sparql.engine.http.Service class does not set any timeout values. HttpQuery will hang if the remote endpoint does not respond.
> I think the solution is to allow the context to specify the timeout values (and perhaps other setter values on HttpQuery). The context should have default values and provide a mechanism to override the defaults based on the URL. Similar to the way query parameters are configured after JENA-195.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira