You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by jd...@apache.org on 2026/09/30 16:24:44 UTC
(grails-core) 02/06: Address IntelliJ inspections in GroovyProxyFactory
This is an automated email from the ASF dual-hosted git repository.
jdaugherty pushed a commit to branch chore/lint-proxy-package
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 89a91e8698b6c65580af1696059882e8e95bde09
Author: Walter Duque de Estrada <wb...@mac.com>
AuthorDate: Sat Aug 15 18:37:17 2026 -0500
Address IntelliJ inspections in GroovyProxyFactory
Mark instance-state-free helper methods static and replace the
deprecated Class.newInstance() with getDeclaredConstructor().newInstance().
Co-Authored-By: Claude Sonnet 5 <no...@anthropic.com>
---
.../org/grails/datastore/gorm/proxy/GroovyProxyFactory.groovy | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/proxy/GroovyProxyFactory.groovy b/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/proxy/GroovyProxyFactory.groovy
index 7f0ca2e47f..d3a1a3f0ae 100644
--- a/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/proxy/GroovyProxyFactory.groovy
+++ b/grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/proxy/GroovyProxyFactory.groovy
@@ -72,7 +72,7 @@ class GroovyProxyFactory implements ProxyFactory {
}
@CompileDynamic
- protected Serializable getIdDynamic(obj) {
+ protected static Serializable getIdDynamic(obj) {
if (obj.respondsTo('getId')) {
return (Serializable)obj.invokeMethod('getId', null)
}
@@ -91,7 +91,7 @@ class GroovyProxyFactory implements ProxyFactory {
@Override
<T> T createProxy(Session session, Class<T> type, Serializable key) {
EntityPersister persister = (EntityPersister) session.getPersister(type)
- T proxy = type.newInstance()
+ T proxy = type.getDeclaredConstructor().newInstance()
if (persister != null) {
persister.setObjectIdentifier(proxy, key)
} else {
@@ -123,7 +123,7 @@ class GroovyProxyFactory implements ProxyFactory {
}
@CompileDynamic
- protected void setMetaClassDynamic(Object proxy, MetaClass proxyMc) {
+ protected static void setMetaClassDynamic(Object proxy, MetaClass proxyMc) {
proxy.setMetaClass(proxyMc)
}
@@ -162,7 +162,7 @@ class GroovyProxyFactory implements ProxyFactory {
return object
}
- protected MetaClass unwrapHandleMetaClass(MetaClass mc) {
+ protected static MetaClass unwrapHandleMetaClass(MetaClass mc) {
if (mc instanceof HandleMetaClass) {
return ((HandleMetaClass) mc).getAdaptee()
}