You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/03 02:28:44 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #4166: Support Browser
protocol at OAP
wu-sheng opened a new issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166
Follow protocol #4164 and design doc https://docs.google.com/document/d/1125WnFCsJnZ98m3H7hplgfkv5MXGJoYdPj-OSr64cDo/edit, implement the logic at the backend.
if @apache/skywalking-committers wants to take over this, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
aderm commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-571916762
Ok i will communicate with him
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
arugal commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570444110
This is an interesting feature, I want to try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
aderm commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-571910037
> 3\. The browser-related sources should be new and separated too all related sources. OAL and antlr should be changed too.
@wu-sheng This sounds interesting, and I hope to participate in antlr related work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570470451
@Fine0830 Your description is the difference between avg and p50 :) That is also why other metrics have p99->p50 to exclude the extreme values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570497448
p50 means 50% of request duration is below the value, which wouldn't be affected by the long tail issue. Same for others. It is very easy to extend from avg to p99->50.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal removed a comment on issue #4166: Support
Browser protocol at OAP
Posted by GitBox <gi...@apache.org>.
arugal removed a comment on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-571144910
> The browser-related sources should be new and separated too all related sources.
A question about `inventory`. I need to use the new `BrowserServiceInventory`,`BrowserServiceInstanceInventory`,`BrowserEndpointInventory`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng edited a comment on issue #4166: Support
Browser protocol at OAP
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570451129
OK, I just assign this to you. Several keys.
1. A new receiver module is required.
1. Register for the endpoint(pagePath) is the first priority work.
1. The browser-related sources should be new and separated too all related sources. OAL and antlr should be changed too.
1. All sources should be designed and discussed first.
### Metrics are following
1. PV for every page(endpoint), version(instance) and service
1. The error rate for every page.
1. TopN page is automatically available by topN query, don't need to implement
1. Error logs for every `BrowserErrorLog`, with rate sampling.
1. Avg value of all fields in PerfDetail.
~~To @Fine0830, a question, what metrics are required for all fields in PerfDetail. Avg time? Maybe.~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] Fine0830 edited a comment on issue #4166: Support
Browser protocol at OAP
Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570454506
> OK, I just assign this to you. Several keys.
>
> 1. A new receiver module is required.
> 2. Register for the endpoint(pagePath) is the first priority work.
> 3. The browser-related sources should be new and separated too all related sources. OAL and antlr should be changed too.
> 4. All sources should be designed and discussed first.
>
> ### Metrics are following
> 1. PV for every page(endpoint), version(instance) and service
> 2. The error rate for every page.
> 3. TopN page is automatically available by topN query, don't need to implement
> 4. Error logs for every `BrowserErrorLog`, with rate sampling.
>
> To @Fine0830, a question, what metrics are required for all fields in PerfDetail. Avg time? Maybe.
Yes. The data is displayed according to the average value of the indicator data in the specified time period. The average value can reflect the average performance over a period of time, but it is easily affected by the extreme value. For example, a user visiting the network is very poor, resulting in the overall page load is very slow, and the average value of the data will be directly pulled up. So I think we can do a filter and use the filter of extremum to remove the extremum and avoid the influence of extremum on the overall trend of performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] Fine0830 commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570454506
> OK, I just assign this to you. Several keys.
>
> 1. A new receiver module is required.
> 2. Register for the endpoint(pagePath) is the first priority work.
> 3. The browser-related sources should be new and separated too all related sources. OAL and antlr should be changed too.
> 4. All sources should be designed and discussed first.
>
> ### Metrics are following
> 1. PV for every page(endpoint), version(instance) and service
> 2. The error rate for every page.
> 3. TopN page is automatically available by topN query, don't need to implement
> 4. Error logs for every `BrowserErrorLog`, with rate sampling.
>
> To @Fine0830, a question, what metrics are required for all fields in PerfDetail. Avg time? Maybe.
Yes. The data is displayed according to the average value of the indicator data in the specified time period. The average value can reflect the average performance over a period of time, but it is easily affected by the extreme value. For example, a user visiting the network is very poor, resulting in the overall page load is very slow, and the average value of the data will be directly pulled up. So I think we can do a filter and use the filter of de extremum to remove the extremum and avoid the influence of extremum on the overall trend of performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-571914324
@aderm , please talk with @arugal . Don't work on duplicated parts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-571871605
@arugal Any update about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570451129
OK, I just assign this to you. Several keys.
1. A new receiver module is required.
1. Register for the endpoint(pagePath) is the first priority work.
1. The browser-related sources should be new and separated too all related sources. OAL and antlr should be changed too.
1. All sources should be designed and discussed first.
### Metrics are following
1. PV for every page(endpoint), version(instance) and service
1. The error rate for every page.
1. TopN page is automatically available by topN query, don't need to implement
1. Error logs for every `BrowserErrorLog`, with rate sampling.
To @Fine0830, a question, what metrics are required for all fields in PerfDetail. Avg time? Maybe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
arugal commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-571144910
> The browser-related sources should be new and separated too all related sources.
A question about `inventory`. I need to use the new `BrowserServiceInventory`,`BrowserServiceInstanceInventory`,`BrowserEndpointInventory`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] Fine0830 commented on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-570496821
Ooh.... I don't quite understand p99->p50. I think `PerfDetail` also need avg value and p99->p50, like other metrics. WDYT @wu-sheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm edited a comment on issue #4166: Support Browser
protocol at OAP
Posted by GitBox <gi...@apache.org>.
aderm edited a comment on issue #4166: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/issues/4166#issuecomment-571910037
> 3\. The browser-related sources should be new and separated too all related sources. OAL and antlr should be changed too.
@wu-sheng This sounds interesting, and I hope to participate in antlr related work，or oap relate is ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services