[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation

["Allan Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612941#comment-16612941 ] 

Allan Yang commented on HBASE-18829:
------------------------------------

Any progress on this? +1 to revert this. Taking the Region's lock (write lock) first and set closing to true later will cause the new coming request waiting on the region's lock(read lock) in startRegionOperation. This is no good, since write lock has priority for Java's ReadWriteLock, the region closing operation will finish first, and those new coming request will still throw a NotServingRegionException to client, the waiting is useless.

> Consider reverting HBASE-14893 Race between mutation on region and region closing operation
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18829
>                 URL: https://issues.apache.org/jira/browse/HBASE-18829
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>         Attachments: 18829.v1.txt, HBASE-18829.patch
>
>
> HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111.
> This issue is to consider reverting the fix from HBASE-14893 based on the following observations:
> * The closing boolean was intended to be acquired before taking the lock ([~enis])
> * Phoenix local index has evolved over the years, the situation leading to NotServingRegionException may not exist from Phoenix side
> * Even if the situation still exists, downstream project (Phoenix) should properly handle NotServingRegionException without change in locking scheme in hbase



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)