You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@paimon.apache.org by lz...@apache.org on 2024/06/20 10:04:29 UTC
(paimon) branch master updated: [minor] Add comments for tag without timeRetained
This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git
The following commit(s) were added to refs/heads/master by this push:
new c46a25697 [minor] Add comments for tag without timeRetained
c46a25697 is described below
commit c46a25697526111c9f6df655a48c2560905c4b72
Author: Jingsong <ji...@gmail.com>
AuthorDate: Thu Jun 20 18:03:07 2024 +0800
[minor] Add comments for tag without timeRetained
---
paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java b/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java
index 6c59ef53c..23675bf9c 100644
--- a/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java
+++ b/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java
@@ -102,6 +102,11 @@ public class TagManager {
} else {
Path newTagPath = tagPath(tagName);
try {
+ // When timeRetained is not defined, please do not write the tagCreatorTime field,
+ // as this will cause older versions (<= 0.7) of readers to be unable to read this
+ // tag.
+ // When timeRetained is defined, it is fine, because timeRetained is the new
+ // feature.
fileIO.writeFileUtf8(
newTagPath,
timeRetained != null