You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/20 12:27:59 UTC

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1134: MINIFICPP-1608 upgrade pybind11 to 2.6.2

adamdebreceni commented on a change in pull request #1134:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1134#discussion_r673071892



##########
File path: thirdparty/pybind11/include/pybind11/attr.h
##########
@@ -12,7 +12,7 @@
 
 #include "cast.h"
 
-NAMESPACE_BEGIN(PYBIND11_NAMESPACE)
+PYBIND11_NAMESPACE_BEGIN(PYBIND11_NAMESPACE)

Review comment:
       could we make this dependency into an external project? there are a few dependencies that are directly committed into `thirdparty`, and I feel like we should minimize their number, this upgrade would be a great excuse to do so with pybind11




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org