You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2024/12/02 15:58:31 UTC
[PR] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests [solr]
epugh opened a new pull request, #2893:
URL: https://github.com/apache/solr/pull/2893
Typos, some dead methods and dead variables.
https://issues.apache.org/jira/browse/SOLR-17579
# Description
Intellij suggested some fixes.
# Solution
Do them and run tests
# Tests
existing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2893:
URL: https://github.com/apache/solr/pull/2893#discussion_r1888333804
##########
solr/CHANGES.txt:
##########
@@ -164,7 +164,8 @@ Dependency Upgrades
Other Changes
---------------------
-(No changes)
+* SOLR-17579: Remove unused code and other refactorings in ReplicationHandler and tests. Removed unused public
Review Comment:
i went back and forth on it, since I'd created a JIRA... I then thought, it should then go in Changes... Plus removing a public variable...
We do need to add to our dev docs a concise "this is what Changes" is for...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #2893:
URL: https://github.com/apache/solr/pull/2893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #2893:
URL: https://github.com/apache/solr/pull/2893#discussion_r1887907887
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1532,7 +1518,8 @@ private Long readIntervalNs(String interval) {
public static final String FETCH_FROM_LEADER = "fetchFromLeader";
// in case of TLOG replica, if leaderVersion = zero, don't do commit
- // otherwise updates from current tlog won't copied over properly to the new tlog, leading to data
+ // otherwise updates from current tlog won't be copied over properly to the new tlog, leading to
+ // data
// loss
// don't commit on leader version zero for PULL replicas as PULL should only get its index
Review Comment:
reflow
##########
solr/CHANGES.txt:
##########
@@ -164,7 +164,8 @@ Dependency Upgrades
Other Changes
---------------------
-(No changes)
+* SOLR-17579: Remove unused code and other refactorings in ReplicationHandler and tests. Removed unused public
Review Comment:
honestly, would any reader of CHANGES.txt care? I'm not questioning your effort in this PR but ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17579: Refactoring suggested by IDE in ReplicationHandler and tests [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #2893:
URL: https://github.com/apache/solr/pull/2893#discussion_r1888332909
##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1532,7 +1518,8 @@ private Long readIntervalNs(String interval) {
public static final String FETCH_FROM_LEADER = "fetchFromLeader";
// in case of TLOG replica, if leaderVersion = zero, don't do commit
- // otherwise updates from current tlog won't copied over properly to the new tlog, leading to data
+ // otherwise updates from current tlog won't be copied over properly to the new tlog, leading to
+ // data
// loss
// don't commit on leader version zero for PULL replicas as PULL should only get its index
Review Comment:
dang it, I trusted `gw tidy` too much..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org