You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "jmjoy (via GitHub)" <gi...@apache.org> on 2023/02/23 05:40:33 UTC
[GitHub] [skywalking-rust] jmjoy opened a new pull request, #55: Add sub components licenses in dist material.
jmjoy opened a new pull request, #55:
URL: https://github.com/apache/skywalking-rust/pull/55
1. Add dist-material directory and LICENSE, NOTICE, licenses files.
2. Update year of NOTICE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #55: Add sub components licenses in dist material.
Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy commented on PR #55:
URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1442993381
The `license-eye` has a bug when generating the LICNESE file for rust project, so skip the CI checking of `dist-meterial/LICNESE` in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng merged pull request #55: Add sub components licenses in dist material.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #55:
URL: https://github.com/apache/skywalking-rust/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] codecov-commenter commented on pull request #55: Add sub components licenses in dist material.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #55:
URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1441244314
# [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/55?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#55](https://codecov.io/gh/apache/skywalking-rust/pull/55?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d69a0dc) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/c39722c870bb79ff159ce441d61b6d564a71c0d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c39722c) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #55 +/- ##
=======================================
Coverage 17.18% 17.18%
=======================================
Files 17 17
Lines 582 582
=======================================
Hits 100 100
Misses 482 482
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #55: Add sub components licenses in dist material.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #55:
URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1449572890
> There is a problem here. The dependent version specified by `Cargo.toml` is not necessarily the version actually used by the user, but the minimum compatible version, while the summary license lists the exact version number. Is there a problem?
We just need to list what we need. If users bump up the version, and license changed(sometimes it happens), then it is user's responsibility
So, I think we are good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #55: Add sub components licenses in dist material.
Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy commented on PR #55:
URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1449481535
There is a problem here. The dependent version specified by `Cargo.toml` is not necessarily the version actually used by the user, but the minimum compatible version, while the summary license lists the exact version number. Is there a problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #55: Add sub components licenses in dist material.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #55:
URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1441275814
> But I don't found NOTICE file in sub component repositories.
If you can't, you don't need to copy anything. Just keep the repository name, version, license in the dist/license file. That is enough.(For Apache 2.0 License). For MIT, BSD, etc., you should copy the license files(ignore NOTICE).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #55: Add sub components licenses in dist material.
Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy commented on PR #55:
URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1441269150
But I don't found NOTICE file in sub component repositories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #55: Add sub components licenses in dist material.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #55:
URL: https://github.com/apache/skywalking-rust/pull/55#issuecomment-1443351542
> The `license-eye` has a bug when generating the LICNESE file for rust project, so skip the CI checking of `dist-meterial/LICNESE` in this PR?
Please report the bug. You could fix it later if you want or Zhenxu maybe has time to help.
For this PR, CI process is not a block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org