You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/08/04 23:26:44 UTC
[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7595
Change subject: log block manager: Reorder class declaration of LogWritableBlock
......................................................................
log block manager: Reorder class declaration of LogWritableBlock
Reordered class declaration of LogWritableBlock to avoid the
intermingling of LogBlockContainer and LogWritableBlock definitions
in future when adding new methods.
Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 71 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/7595/1
--
To view, visit http://gerrit.cloudera.org:8080/7595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has uploaded a new patch set (#2).
Change subject: log block manager: Reorder class declaration of LogWritableBlock
......................................................................
log block manager: Reorder class declaration of LogWritableBlock
Reordered class declaration of LogWritableBlock to avoid the
intermingling of LogBlockContainer and LogWritableBlock definitions
in future when adding new methods.
Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 71 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/7595/2
--
To view, visit http://gerrit.cloudera.org:8080/7595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7595
to look at the new patch set (#3).
Change subject: log block manager: Reorder class declaration of LogWritableBlock
......................................................................
log block manager: Reorder class declaration of LogWritableBlock
Reordered class declaration of LogWritableBlock to avoid the
intermingling of LogBlockContainer and LogWritableBlock definitions
in future when adding new methods.
Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 69 insertions(+), 65 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/7595/3
--
To view, visit http://gerrit.cloudera.org:8080/7595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: log block manager: Reorder class declaration of LogWritableBlock
......................................................................
log block manager: Reorder class declaration of LogWritableBlock
Reordered class declaration of LogWritableBlock to avoid the
intermingling of LogBlockContainer and LogWritableBlock definitions
in future when adding new methods.
Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
Reviewed-on: http://gerrit.cloudera.org:8080/7595
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/fs/log_block_manager.cc
1 file changed, 69 insertions(+), 65 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: log block manager: Reorder class declaration of LogWritableBlock
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7595/2/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:
Line 223: ////////////////////////////////////////////////////////////
> This actually isn't necessary; LogBlock above already references LogBlockCo
Done
--
To view, visit http://gerrit.cloudera.org:8080/7595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: log block manager: Reorder class declaration of LogWritableBlock
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7595/2/src/kudu/fs/log_block_manager.cc
File src/kudu/fs/log_block_manager.cc:
Line 223: class LogBlockContainer;
This actually isn't necessary; LogBlock above already references LogBlockContainer by pointer and the class is forward declared in log_block_manager.h.
--
To view, visit http://gerrit.cloudera.org:8080/7595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] log block manager: Reorder class declaration of LogWritableBlock
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: log block manager: Reorder class declaration of LogWritableBlock
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5192cccac1931fd1f65b11fa0739090e8368e2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No