You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/02 06:42:41 UTC

Review Request 54289: Added a check to require I/O switchboard server for TTY support.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54289/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Kevin Klues.


Repository: mesos


Description
-------

Added a check to require I/O switchboard server for TTY support.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 594c37e531c5b26599989a126aede56954d460fa 

Diff: https://reviews.apache.org/r/54289/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 54289: Added a check to require I/O switchboard server for TTY support.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54289/#review157945
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Hindman


On Dec. 2, 2016, 6:29 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54289/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 6:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kevin Klues.
> 
> 
> Bugs: MESOS-6470
>     https://issues.apache.org/jira/browse/MESOS-6470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a check to require I/O switchboard server for TTY support.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 594c37e531c5b26599989a126aede56954d460fa 
> 
> Diff: https://reviews.apache.org/r/54289/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 54289: Added a check to require I/O switchboard server for TTY support.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54289/#review157796
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Dec. 2, 2016, 6:29 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54289/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 6:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kevin Klues.
> 
> 
> Bugs: MESOS-6470
>     https://issues.apache.org/jira/browse/MESOS-6470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a check to require I/O switchboard server for TTY support.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 594c37e531c5b26599989a126aede56954d460fa 
> 
> Diff: https://reviews.apache.org/r/54289/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Re: Review Request 54289: Added a check to require I/O switchboard server for TTY support.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54289/
-----------------------------------------------------------

(Updated Dec. 5, 2016, 5:33 a.m.)


Review request for mesos, Benjamin Hindman and Kevin Klues.


Changes
-------

Rebased.


Bugs: MESOS-6470
    https://issues.apache.org/jira/browse/MESOS-6470


Repository: mesos


Description
-------

Added a check to require I/O switchboard server for TTY support.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 778367a268ec350ed438bc9fe9d359d63bdb5503 

Diff: https://reviews.apache.org/r/54289/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 54289: Added a check to require I/O switchboard server for TTY support.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54289/
-----------------------------------------------------------

(Updated Dec. 2, 2016, 6:29 p.m.)


Review request for mesos, Benjamin Hindman and Kevin Klues.


Bugs: MESOS-6470
    https://issues.apache.org/jira/browse/MESOS-6470


Repository: mesos


Description
-------

Added a check to require I/O switchboard server for TTY support.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 594c37e531c5b26599989a126aede56954d460fa 

Diff: https://reviews.apache.org/r/54289/diff/


Testing
-------

make check


Thanks,

Jie Yu