You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/04 10:59:05 UTC
[GitHub] [tvm] NaNAGISaSA opened a new pull request, #12303: [AutoTVM][Fix] Fix wrong axis names of data_vec
NaNAGISaSA opened a new pull request, #12303:
URL: https://github.com/apache/tvm/pull/12303
This PR is trying to fix the wrong axis names of data_vec. As the data_vec is nchwc format, the axis names should be `batch, ic_chunk, ih, iw, ic_block`, but not `batch, ic_chunk, ih, ic_block, iw`.
Although the following code does not use these last two axises, so it does not cause some bugs for now. But I think we should fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige merged pull request #12303: [AutoTVM][Fix] Fix wrong axis names of data_vec
Posted by GitBox <gi...@apache.org>.
tkonolige merged PR #12303:
URL: https://github.com/apache/tvm/pull/12303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NaNAGISaSA commented on pull request #12303: [AutoTVM][Fix] Fix wrong axis names of data_vec
Posted by GitBox <gi...@apache.org>.
NaNAGISaSA commented on PR #12303:
URL: https://github.com/apache/tvm/pull/12303#issuecomment-1205107001
cc: @yzhliu, @tkonolige
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #12303: [AutoTVM][Fix] Fix wrong axis names of data_vec
Posted by GitBox <gi...@apache.org>.
tkonolige commented on PR #12303:
URL: https://github.com/apache/tvm/pull/12303#issuecomment-1208436649
@NaNAGISaSA have to tested performance before and after this change? The change in names is correct but I wonder if you need to change the reorder code below it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NaNAGISaSA commented on pull request #12303: [AutoTVM][Fix] Fix wrong axis names of data_vec
Posted by GitBox <gi...@apache.org>.
NaNAGISaSA commented on PR #12303:
URL: https://github.com/apache/tvm/pull/12303#issuecomment-1208867049
Hi, @tkonolige , thank you for your review.
I think we do not need to change the reorder code below, here is the benchmark result and code analysis:
### Benchmark
- Model: ResNet50 With Quantization
- Backend: Intel(R) Core(TM) i7-9700 CPU @ 3.00GHz
- Threads: 4
- Benchmark Before Change:
```
Execution time summary:
mean (ms) median (ms) max (ms) min (ms) std (ms)
586.5478 586.6723 587.4650 585.2788 0.7180
```
- Benchmark After Change:
```
Execution time summary:
mean (ms) median (ms) max (ms) min (ms) std (ms)
584.4176 585.1300 586.2465 580.8972 1.8741
```
So we can see that the benchmark result for ResNet50 before and after changing the code is equal.
### Code Analysis
In the context of the changes, for `iw` variable, it is not used in the following code in its function. And for `ic_block` variable, it is reassigned immediately with the `ic_block` axis for `kernel_vec` in the following line 170 and 308, so this change will also not influence the following code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] NaNAGISaSA commented on pull request #12303: [AutoTVM][Fix] Fix wrong axis names of data_vec
Posted by GitBox <gi...@apache.org>.
NaNAGISaSA commented on PR #12303:
URL: https://github.com/apache/tvm/pull/12303#issuecomment-1208868095
The benchmark result is acquired with `module.benchmark(dev, number=100, repeat=5)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org