You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/07 09:10:44 UTC
[GitHub] [maven-ejb-plugin] pzygielo opened a new pull request #11: Accept ejbVersion 4.x
pzygielo opened a new pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MEJB) filed for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MEJB-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MEJB-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ejb-plugin] andreastedile commented on pull request #11: [MEJB-130] Accept ejbVersion 4.x
Posted by GitBox <gi...@apache.org>.
andreastedile commented on pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11#issuecomment-743847758
I would be interested for EJB version 4 too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ejb-plugin] elharo merged pull request #11: [MEJB-130] Accept ejbVersion 4.x
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ejb-plugin] elharo commented on pull request #11: [MEJB-130] Accept ejbVersion 4.x
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11#issuecomment-752639839
Running through Jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ejb-plugin/job/mejb-130/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ejb-plugin] elharo commented on a change in pull request #11: [MEJB-130] Accept ejbVersion 4.x
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11#discussion_r549387107
##########
File path: src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java
##########
@@ -465,10 +465,10 @@ private File generateEjbClient()
private void checkEJBVersionCompliance( File deploymentDescriptor )
throws MojoExecutionException
{
- if ( !ejbVersion.matches( "\\A[2-3]\\.[0-9]\\z" ) )
+ if ( !ejbVersion.matches( "\\A[2-4]\\.[0-9]\\z" ) )
Review comment:
a unit test would be easier to manage than an integration test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ejb-plugin] pzygielo commented on pull request #11: [MEJB-130] Accept ejbVersion 4.x
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11#issuecomment-739791557
May I ask for review, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-ejb-plugin] pzygielo commented on a change in pull request #11: [MEJB-130] Accept ejbVersion 4.x
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11#discussion_r549431440
##########
File path: src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java
##########
@@ -465,10 +465,10 @@ private File generateEjbClient()
private void checkEJBVersionCompliance( File deploymentDescriptor )
throws MojoExecutionException
{
- if ( !ejbVersion.matches( "\\A[2-3]\\.[0-9]\\z" ) )
+ if ( !ejbVersion.matches( "\\A[2-4]\\.[0-9]\\z" ) )
Review comment:
> a unit test would be easier to manage than an integration test
IT replaced with UTs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org