You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Csaba Ringhofer (JIRA)" <ji...@apache.org> on 2018/09/03 17:46:00 UTC

[jira] [Commented] (IMPALA-7417) Speed up sub-second unix time->TimestampValue conversions

    [ https://issues.apache.org/jira/browse/IMPALA-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602374#comment-16602374 ] 

Csaba Ringhofer commented on IMPALA-7417:
-----------------------------------------

It turned out that the fix for IMPALA-7147 was committed with this Jira's id by mistake. I have cloned this issue (IMPALA-7521) and changed the review to point to the new issue to avoid confusion in the future. This issue will be probably rewritten to be the duplicate of IMPALA-7147.

> Speed up sub-second unix time->TimestampValue conversions
> ---------------------------------------------------------
>
>                 Key: IMPALA-7417
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7417
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Csaba Ringhofer
>            Assignee: Csaba Ringhofer
>            Priority: Major
>              Labels: performance, timestamp
>
> Currently Impala converts from sub-second unix time to TimestampValue (which is split do date_ and time_ similarly to boost::posix_time::ptime ) by first splitting the input into seconds and sub-seconds part, converting the seconds part with  boost::posix_time::from_time_t(), and then adding the sub-seconds part to this timestamp. This can be done much faster  by splitting the sub-second input into date_ and time_ directly.
> Avoiding boost::posix_time::from_time_t() would be also nice because it can only deal with timestamps from 1677 to 2262, which adds extra complexity to the related code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org