You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/03/19 03:30:28 UTC
Review Request 32229: SQOOP-1949 HDFS - Support at least append-only
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32229/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOP-1949
https://issues.apache.org/jira/browse/SQOP-1949
Repository: sqoop-sqoop2
Description
-------
Added the last step to support the append mode.
Diffs
-----
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 05ceb23
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java 6fc894b
connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 8d5a562
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java aa267a7
test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java b115723
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/32229/diff/
Testing
-------
Added both unit and integration test(s).
Thanks,
Jarek Cecho
Re: Review Request 32229: SQOOP-1949 HDFS - Support at least
append-only
Posted by Jarek Cecho <ja...@apache.org>.
> On March 19, 2015, 2:46 a.m., Abraham Elmahrek wrote:
> > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java, line 51
> > <https://reviews.apache.org/r/32229/diff/1/?file=899588#file899588line51>
> >
> > Boolean.TRUE.equals(jobConfig.toJobConfig.appendMode);
Good suggestion!
> On March 19, 2015, 2:46 a.m., Abraham Elmahrek wrote:
> > test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java, line 53
> > <https://reviews.apache.org/r/32229/diff/1/?file=899592#file899592line53>
> >
> > Maybe support both Set and List? For example some tests will only want at most 1 of an item, while the incremental tests would want to append.
I'll use MultiSet then - seems as the best of both worlds.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32229/#review77002
-----------------------------------------------------------
On March 19, 2015, 2:30 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32229/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 2:30 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOP-1949
> https://issues.apache.org/jira/browse/SQOP-1949
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added the last step to support the append mode.
>
>
> Diffs
> -----
>
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 05ceb23
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java 6fc894b
> connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 8d5a562
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java aa267a7
> test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java b115723
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32229/diff/
>
>
> Testing
> -------
>
> Added both unit and integration test(s).
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32229: SQOOP-1949 HDFS - Support at least
append-only
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32229/#review77002
-----------------------------------------------------------
Ship it!
LGTM if tests pass.
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java
<https://reviews.apache.org/r/32229/#comment124750>
Boolean.TRUE.equals(jobConfig.toJobConfig.appendMode);
test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java
<https://reviews.apache.org/r/32229/#comment124751>
Maybe support both Set and List? For example some tests will only want at most 1 of an item, while the incremental tests would want to append.
- Abraham Elmahrek
On March 19, 2015, 2:30 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32229/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 2:30 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOP-1949
> https://issues.apache.org/jira/browse/SQOP-1949
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added the last step to support the append mode.
>
>
> Diffs
> -----
>
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 05ceb23
> connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java 6fc894b
> connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 8d5a562
> connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java aa267a7
> test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java b115723
> test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32229/diff/
>
>
> Testing
> -------
>
> Added both unit and integration test(s).
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32229: SQOOP-1949 HDFS - Support at least
append-only
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32229/
-----------------------------------------------------------
(Updated March 19, 2015, 4:26 a.m.)
Review request for Sqoop.
Changes
-------
Incorporated feedback.
Bugs: SQOP-1949
https://issues.apache.org/jira/browse/SQOP-1949
Repository: sqoop-sqoop2
Description
-------
Added the last step to support the append mode.
Diffs (updated)
-----
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java 05ceb23
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java 6fc894b
connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 8d5a562
connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java aa267a7
test/src/main/java/org/apache/sqoop/test/asserts/HdfsAsserts.java b115723
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/32229/diff/
Testing
-------
Added both unit and integration test(s).
Thanks,
Jarek Cecho