You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/01/08 23:09:45 UTC

[GitHub] [accumulo] brianloss edited a comment on pull request #1862: Use long instead of int for monitor scan rate (fixes #1858)

brianloss edited a comment on pull request #1862:
URL: https://github.com/apache/accumulo/pull/1862#issuecomment-757041885


   > All files added to `monitor/resources/external/` should be added without modification. From where were these obtained? And were they added without modification?
   > 
   > The following LICENSE files have been modified to reflect our redistribution of flot code. They must be updated to properly reflect the updated version of flot.
   > 
   > * assemble/src/main/resources/LICENSE
   > * LICENSE
   > * server/monitor/src/main/appended-resources/META-INF/LICENSE
   > 
   > Aside from the license issues, these changes look fine to me.
   
   I downloaded it from their [releases page](https://github.com/flot/flot/releases) and inserted the source files unmodified. AFAICT, the license file hasn't been updated since 2014 and shows no differences from the currently checked in license file [here](https://github.com/apache/accumulo/blob/main/server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/external/flot/LICENSE.txt). Therefore, I'm not sure what I'd update in the files you reference. I didn't see the flot version referenced in them anywhere.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org