You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "szymon-czapracki (via GitHub)" <gi...@apache.org> on 2024/08/08 13:41:39 UTC
[PR] nimble/audio/bass: Add data length check in BASS remote scan [mynewt-nimble]
szymon-czapracki opened a new pull request, #1834:
URL: https://github.com/apache/mynewt-nimble/pull/1834
Add data length checks to remote scan operations. Now any data coming with remote scan start/stop will result in instant ATT error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/audio/bass: Add data length check in BASS remote scan [mynewt-nimble]
Posted by "rymanluk (via GitHub)" <gi...@apache.org>.
rymanluk commented on code in PR #1834:
URL: https://github.com/apache/mynewt-nimble/pull/1834#discussion_r1721326359
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -251,6 +251,10 @@ ble_svc_audio_bass_receive_state_free(struct ble_svc_audio_bass_rcv_state_entry
static int
ble_svc_audio_bass_remote_scan_stopped(uint8_t *data, uint16_t data_len, uint16_t conn_handle)
{
+ if (data_len > 1) {
Review Comment:
indentation .
and the error could seems to be BLE_ATT_ERR_WRITE_REQ_REJECTED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/audio/bass: Add data length check in BASS remote scan [mynewt-nimble]
Posted by "rymanluk (via GitHub)" <gi...@apache.org>.
rymanluk commented on code in PR #1834:
URL: https://github.com/apache/mynewt-nimble/pull/1834#discussion_r1721326562
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -264,6 +268,10 @@ ble_svc_audio_bass_remote_scan_stopped(uint8_t *data, uint16_t data_len, uint16_
static int
ble_svc_audio_bass_remote_scan_started(uint8_t *data, uint16_t data_len, uint16_t conn_handle)
{
+ if (data_len > 1) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/audio/bass: Add data length check in BASS remote scan [mynewt-nimble]
Posted by "szymon-czapracki (via GitHub)" <gi...@apache.org>.
szymon-czapracki commented on code in PR #1834:
URL: https://github.com/apache/mynewt-nimble/pull/1834#discussion_r1727059252
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -251,6 +251,10 @@ ble_svc_audio_bass_receive_state_free(struct ble_svc_audio_bass_rcv_state_entry
static int
ble_svc_audio_bass_remote_scan_stopped(uint8_t *data, uint16_t data_len, uint16_t conn_handle)
{
+ if (data_len > 1) {
Review Comment:
Done
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -264,6 +268,10 @@ ble_svc_audio_bass_remote_scan_stopped(uint8_t *data, uint16_t data_len, uint16_
static int
ble_svc_audio_bass_remote_scan_started(uint8_t *data, uint16_t data_len, uint16_t conn_handle)
{
+ if (data_len > 1) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/audio/bass: Add data length check in BASS remote scan [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1834:
URL: https://github.com/apache/mynewt-nimble/pull/1834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org