You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/13 09:16:21 UTC
[PR] fix(web): guard null principal and resource in ACL rule search [rocketmq-dashboard]
btlqql opened a new pull request, #2105:
URL: https://github.com/apache/rocketmq-dashboard/pull/2105
## What is the purpose of the change
Fix #2104.
The ACL rules filter called r.principal.toLowerCase() and r.resource.toLowerCase() without guarding null values from the backend, crashing when a rule has no principal/resource.
## Brief changelog
- acl.tsx: use r.principal?.toLowerCase() and r.resource?.toLowerCase()
## How was this patch verified
- npx vitest run src/pages/instance/__tests__/AclPage.test.tsx (13 passed)
- npx tsc -b clean
- npx eslint . clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): guard null principal and resource in ACL rule search [rocketmq-dashboard]
Posted by "btlqql (via GitHub)" <gi...@apache.org>.
btlqql commented on PR #2105:
URL: https://github.com/apache/rocketmq-dashboard/pull/2105#issuecomment-5279238885
The automated review looked at the master branch, but this PR targets rocketmq-studio where web/src/pages/instance/acl.tsx lines 188-189 still call r.principal.toLowerCase() and r.resource.toLowerCase() without a null guard. The String(val).toLowerCase() wrapper the review mentions is in the user search filter, not the rule filter. This fix adds the missing guard for the rule filter on rocketmq-studio.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): guard null principal and resource in ACL rule search [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2105:
URL: https://github.com/apache/rocketmq-dashboard/pull/2105#issuecomment-5291350395
Closing per contribution guideline #2107: these are fragmented one-off changes of the same theme (one PR per guard/fix/page). Please group related changes into cohesive pull requests and resubmit — your contributions are welcome in a consolidated shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(web): guard null principal and resource in ACL rule search [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2105: fix(web): guard null principal and resource in ACL rule search
URL: https://github.com/apache/rocketmq-dashboard/pull/2105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org