You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/07/18 22:50:13 UTC
Review Request 12743: removed unused class and related test utils
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12743/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
MethodCapturer and related test utilities was not used
Diffs
-----
utils/src/com/cloud/utils/MethodCapturer.java f9fe046
utils/test/com/cloud/utils/DummyImpl.java 467d8e2
utils/test/com/cloud/utils/DummyInterface.java f79a53e
utils/test/com/cloud/utils/DummyPremiumImpl.java bf8bfea
Diff: https://reviews.apache.org/r/12743/diff/
Testing
-------
Thanks,
Laszlo Hornyak
Re: Review Request 12743: removed unused class and related test utils
Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12743/#review23486
-----------------------------------------------------------
Hi,
Indeed it looks like it is coming from the vmsync branch, it does have a test there but I do not see any other code built on it at the moment. Anyway, if you need this class please tell me and I will discard this patch.
Thank you,
Laszlo
- Laszlo Hornyak
On July 18, 2013, 10:53 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12743/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 10:53 p.m.)
>
>
> Review request for cloudstack and Kelven Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> MethodCapturer and related test utilities was not used
>
>
> Diffs
> -----
>
> utils/src/com/cloud/utils/MethodCapturer.java f9fe046
> utils/test/com/cloud/utils/DummyImpl.java 467d8e2
> utils/test/com/cloud/utils/DummyInterface.java f79a53e
> utils/test/com/cloud/utils/DummyPremiumImpl.java bf8bfea
>
> Diff: https://reviews.apache.org/r/12743/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 12743: removed unused class and related test utils
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12743/
-----------------------------------------------------------
(Updated July 18, 2013, 10:53 p.m.)
Review request for cloudstack and Kelven Yang.
Changes
-------
Kelven, it's related to your unmerged VMsync code. Is it OK to remove it for now?
Repository: cloudstack-git
Description
-------
MethodCapturer and related test utilities was not used
Diffs
-----
utils/src/com/cloud/utils/MethodCapturer.java f9fe046
utils/test/com/cloud/utils/DummyImpl.java 467d8e2
utils/test/com/cloud/utils/DummyInterface.java f79a53e
utils/test/com/cloud/utils/DummyPremiumImpl.java bf8bfea
Diff: https://reviews.apache.org/r/12743/diff/
Testing
-------
Thanks,
Laszlo Hornyak