You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2016/01/18 17:39:44 UTC
[GitHub] couchdb-fauxton pull request: Minor extensibility tweaks
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/610
Minor extensibility tweaks
This PR contains a bunch of really small unrelated changes
for general extensibility.
- optional top-level class added to Tray component
- QueryOptions component now exposed for use elsewhere
- MainFieldsView query options component now accepts the doc URL
via a prop.
- Improvement for Up arrow on the query options tray placement
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton minor-extensibility-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/610.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #610
----
commit bd2a4deb6b7999be7f7343eb6a6b7d29271f506c
Author: Ben Keen <be...@gmail.com>
Date: 2016-01-18T16:19:20Z
Minor extensibility tweaks
This PR contains a bunch of really small unrelated changes
for general extensibility.
- optional top-level class added to Tray component
- QueryOptions component now exposed for use elsewhere
- MainFieldsView query options component now accepts the doc URL
via a prop.
- Improvement for Up arrow on the query options tray placement
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extensibility tweaks
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#issuecomment-172584006
thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extensibility tweaks
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/610
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extensibility tweaks
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#discussion_r50020176
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -83,14 +97,15 @@ function (app, FauxtonAPI, React, Stores, Actions, Components) {
<div className="query-group" id="query-options-main-fields">
<span className="add-on">
Query Options
- <a className="help-link" href={FauxtonAPI.constants.DOC_URLS.GENERAL} target="_blank" data-bypass="true">
+ <a className="help-link" href={this.props.docURL} target="_blank" data-bypass="true">
<i className="icon-question-sign" />
</a>
</span>
<div className="controls-group qo-main-fields-row">
<div className="row-fluid fieldsets">
<div className="checkbox inline">
- <input disabled={this.props.reduce} onChange={this.toggleIncludeDocs} className="boom" id="qoIncludeDocs" name="include_docs" type="checkbox" checked={includeDocs} />
+ <input disabled={this.props.reduce} onChange={this.toggleIncludeDocs} className="boom" id="qoIncludeDocs"
--- End diff --
haha I doubt it!! Didn't notice that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extensibility tweaks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#discussion_r50019691
--- Diff: app/addons/documents/header/header.react.jsx ---
@@ -43,7 +43,7 @@ function (app, FauxtonAPI, React, Actions, ReactComponents,
selectedView: indexResultsStore.getCurrentViewType(),
isTableView: indexResultsStore.getIsTableView(),
includeDocs: queryOptionsStore.getIncludeDocsEnabled(),
- bulkDocCollection: indexResultsStore.getBulkDocCollection(),
+ bulkDocCollection: indexResultsStore.getBulkDocCollection()
--- End diff --
note: commas at the end are not harmful, they were back in IE6 or IE8 ages which was not acting according to the ES spec. leaving the commas makes it easier to add things in the future
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extensibility tweaks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#discussion_r50019823
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -83,14 +97,15 @@ function (app, FauxtonAPI, React, Stores, Actions, Components) {
<div className="query-group" id="query-options-main-fields">
<span className="add-on">
Query Options
- <a className="help-link" href={FauxtonAPI.constants.DOC_URLS.GENERAL} target="_blank" data-bypass="true">
+ <a className="help-link" href={this.props.docURL} target="_blank" data-bypass="true">
<i className="icon-question-sign" />
</a>
</span>
<div className="controls-group qo-main-fields-row">
<div className="row-fluid fieldsets">
<div className="checkbox inline">
- <input disabled={this.props.reduce} onChange={this.toggleIncludeDocs} className="boom" id="qoIncludeDocs" name="include_docs" type="checkbox" checked={includeDocs} />
+ <input disabled={this.props.reduce} onChange={this.toggleIncludeDocs} className="boom" id="qoIncludeDocs"
--- End diff --
i think the className boom is not used, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extensibility tweaks
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#discussion_r50020251
--- Diff: app/addons/documents/header/header.react.jsx ---
@@ -43,7 +43,7 @@ function (app, FauxtonAPI, React, Actions, ReactComponents,
selectedView: indexResultsStore.getCurrentViewType(),
isTableView: indexResultsStore.getIsTableView(),
includeDocs: queryOptionsStore.getIncludeDocsEnabled(),
- bulkDocCollection: indexResultsStore.getBulkDocCollection(),
+ bulkDocCollection: indexResultsStore.getBulkDocCollection()
--- End diff --
Yeah I know they're not harmful - they just look funky to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Minor extensibility tweaks
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/610#issuecomment-172583189
code looks good, +1 after addressing the classname issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---