You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alan Conway (JIRA)" <qp...@incubator.apache.org> on 2010/04/19 17:06:54 UTC
[jira] Commented: (QPID-2492) Changes to brokertest.py to better
manage Windows brokers
[ https://issues.apache.org/jira/browse/QPID-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858544#action_12858544 ]
Alan Conway commented on QPID-2492:
-----------------------------------
I've got 2 concerns with this patch:
1. I deliberately did not use the subprocess module so this could would run on python 2,3. Is it essential to use subprocess in order for this to work on windows?
2. Why did you comment out draining of stderr? We need to capture stderr output from failed processes to diagnose test failures.
> Changes to brokertest.py to better manage Windows brokers
> ---------------------------------------------------------
>
> Key: QPID-2492
> URL: https://issues.apache.org/jira/browse/QPID-2492
> Project: Qpid
> Issue Type: Improvement
> Components: Python Test Suite
> Affects Versions: 0.7
> Reporter: Steve Huston
> Attachments: brokertest.diff
>
>
> I've been developing tests for the persistence/store functionality using python/qpid/brokertest.py and I've made some local changes to get this to work well on Windows. I'm a Python beginner, and there may be better ways to do what I've done. Could someone please review the patch here and let me know any suggestions?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org