You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/05/25 11:03:42 UTC

[GitHub] [netbeans] tmysik commented on a change in pull request #2155: [NETBEANS-4368] Fix test file navigation dialog

tmysik commented on a change in pull request #2155:
URL: https://github.com/apache/netbeans/pull/2155#discussion_r429874975



##########
File path: php/php.project/src/org/netbeans/modules/php/project/ui/actions/tests/GoToTest.java
##########
@@ -54,6 +55,14 @@
     private static final Logger LOGGER = Logger.getLogger(GoToTest.class.getName());
     private static final RequestProcessor RP = new RequestProcessor(GoToTest.class.getName(), 2);
 
+    private static class FileObjectComparator implements Comparator<FileObject> {

Review comment:
       Just a note: I usually put the inner classes at the very end of the class (usually below `//~ Inner classes` comment). No need to change it in this PR, I just think it makes the code more readable (main class and then inner classes, not mixed).
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists