You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "David Valeri (JIRA)" <ji...@apache.org> on 2010/04/16 18:40:25 UTC
[jira] Created: (CAMEL-2652) Allow camel-jetty to enable Jetty JMX
extensions
Allow camel-jetty to enable Jetty JMX extensions
------------------------------------------------
Key: CAMEL-2652
URL: https://issues.apache.org/activemq/browse/CAMEL-2652
Project: Apache Camel
Issue Type: Improvement
Components: camel-jetty, karaf, tests
Affects Versions: 2.3.0
Reporter: David Valeri
Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (CAMEL-2652) Allow camel-jetty to enable Jetty JMX
extensions
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-2652.
--------------------------------
Fix Version/s: 2.3.0
Resolution: Fixed
trunk: 936173.
Thanks David I have applied the patch
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Fix For: 2.3.0
>
> Attachments: CAMEL-2652-2.patch, CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2652) Allow camel-jetty to enable Jetty JMX
extensions
Posted by "David Valeri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Valeri updated CAMEL-2652:
--------------------------------
Attachment: CAMEL-2652.patch
Proposed solution attached.
The solution allows the Camel JMX enable/disable capability to override the new configuration parameter and uses one instance of the Jetty MBeanContainer to prevent Jetty MBean name collisions when running multiple endpoints with JMX enabled in Jetty.
Note that the Karaf test changes were needed for:
1) Without depends plug-in version specified, m2Eclipse does not want to import the project.
2) camel-osgi feature was removed recently but the abstract test case still looks to load this feature causing all tests to fail.
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CAMEL-2652) Allow camel-jetty to enable Jetty
JMX extensions
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58970#action_58970 ]
Claus Ibsen commented on CAMEL-2652:
------------------------------------
The current patch is a bit flaky when you have disabled JMX as it will create a MBeanServer when stopping because it calls {getMbContainer()}}.
There should be some boolean flag which indicates if there is a MbContainer or not
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2652) Allow camel-jetty to enable Jetty
JMX extensions
Posted by "David Valeri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58913#action_58913 ]
David Valeri commented on CAMEL-2652:
-------------------------------------
I'd be happy to provide end-user documentation as well.
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CAMEL-2652) Allow camel-jetty to enable Jetty
JMX extensions
Posted by "David Valeri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58957#action_58957 ]
David Valeri commented on CAMEL-2652:
-------------------------------------
@Willem
Documentation is written, but the wiki is timing out when I try to post the changes. I'll let you know when I finally get them added.
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2652) Allow camel-jetty to enable Jetty JMX
extensions
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-2652:
-----------------------------------
Assignee: Willem Jiang
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CAMEL-2652) Allow camel-jetty to enable Jetty JMX
extensions
Posted by "David Valeri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Valeri updated CAMEL-2652:
--------------------------------
Attachment: CAMEL-2652-2.patch
Attached second patch to prevent unnecessary creation of MBeanContainer during component shutdown.
Documentation has also been updated in the wiki.
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Attachments: CAMEL-2652-2.patch, CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2652) Allow camel-jetty to enable Jetty
JMX extensions
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58923#action_58923 ]
Willem Jiang commented on CAMEL-2652:
-------------------------------------
Just committed the patch[1] with the suggestion of Claus.
http://svn.apache.org/viewvc?view=revision&revision=935160
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CAMEL-2652) Allow camel-jetty to enable Jetty
JMX extensions
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58917#action_58917 ]
Willem Jiang commented on CAMEL-2652:
-------------------------------------
Applied the patch with thanks to David.
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CAMEL-2652) Allow camel-jetty to enable Jetty
JMX extensions
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58918#action_58918 ]
Willem Jiang commented on CAMEL-2652:
-------------------------------------
@David,
When you update the wiki page, I will make this issue resolved.
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CAMEL-2652) Allow camel-jetty to enable Jetty
JMX extensions
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58919#action_58919 ]
Claus Ibsen commented on CAMEL-2652:
------------------------------------
Good patch.
However I would like if it was possible to set the {{enableJMX}} option on the {{JettyHttpComponent}} so you can enable this more easily.
And then the endpoint parameter can override that option, if it was provided in the endpoint uri.
Also the FATAL log is a bit harsh, as its not FATAL as the application can still run, the exception is just logged etc. So please set that as WARN or ERROR.
> Allow camel-jetty to enable Jetty JMX extensions
> ------------------------------------------------
>
> Key: CAMEL-2652
> URL: https://issues.apache.org/activemq/browse/CAMEL-2652
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-jetty, karaf, tests
> Affects Versions: 2.3.0
> Reporter: David Valeri
> Assignee: Willem Jiang
> Attachments: CAMEL-2652.patch
>
>
> Provide a URL parameter to allow users to enable Jetty's JMX support when Camel JMX support is enabled.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira