[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #15187: Improve static cached_op optimization

[GitBox <gi...@apache.org>]

ZhennanQin commented on a change in pull request #15187: Improve static cached_op optimization
URL: https://github.com/apache/incubator-mxnet/pull/15187#discussion_r292415224
 
 

 ##########
 File path: src/imperative/imperative_utils.h
 ##########
 @@ -595,7 +595,10 @@ inline bool CheckAndInferShape(nnvm::Graph* p_g, mxnet::ShapeVector&& shapes,
     *contain_unknown = false;
   }
   nnvm::Graph& g = *p_g;
-  if (g.attrs.count("shape")) {
+  if (use_inputs) {
 
 Review comment:
   This code is removed from previous commit by mistake. This is just to recover them back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services