You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@archiva.apache.org by Martin <ma...@apache.org> on 2016/10/03 18:00:46 UTC
Authenticator change
Hi Olivier,
I think my last commits to the master that should improve the error handling,
if LDAP is not configured properly, shifted the problem to a new location.
The LDAP authentication is not mandatory, if I see this correctly.
Problem is, that if LDAP is not configured correctly a autowiring exception
occurs at the next start, because the LdapConnectionFactory cannot be
initialized. Which leads to a complete startup failure. I'm not sure, if this
was the case before my commit.
I think exceptions during autowiring, are only OK for mandatory beans, but the
LDAPAuthenticator is not mandatory.
My fix needs a new method isValid() of the Authenticator and
LdapConnectionFactory-Interfaces.
I added the fix to a new branch 'validauth' for review. Could you please
check, if this is the right way.
The unit tests are not checked in this branch. I will adapt them, if you agree
to the implementation.
Greetings
Martin
Re: Authenticator change
Posted by Martin <ma...@apache.org>.
Ah, thanks for the hint. This is the issue, yes. Didn't recognize it.
So, I will prepare the branch for release to the master, have to check the
unit tests before.
Greetings
Martin
Am Mittwoch, 5. Oktober 2016, 08:09:17 CEST schrieb Olivier Lamy:
> Hi
> LGTLM.
> Related to https://issues.apache.org/jira/browse/MRM-1907 ?
>
> Cheers
> Olivier
>
> On 4 October 2016 at 05:00, Martin <ma...@apache.org> wrote:
> > Hi Olivier,
> >
> > I think my last commits to the master that should improve the error
> > handling,
> > if LDAP is not configured properly, shifted the problem to a new location.
> >
> > The LDAP authentication is not mandatory, if I see this correctly.
> >
> > Problem is, that if LDAP is not configured correctly a autowiring
> > exception
> > occurs at the next start, because the LdapConnectionFactory cannot be
> > initialized. Which leads to a complete startup failure. I'm not sure, if
> > this
> > was the case before my commit.
> >
> > I think exceptions during autowiring, are only OK for mandatory beans, but
> > the
> > LDAPAuthenticator is not mandatory.
> > My fix needs a new method isValid() of the Authenticator and
> > LdapConnectionFactory-Interfaces.
> > I added the fix to a new branch 'validauth' for review. Could you please
> > check, if this is the right way.
> > The unit tests are not checked in this branch. I will adapt them, if you
> > agree
> > to the implementation.
> >
> > Greetings
> >
> > Martin
Re: Authenticator change
Posted by Olivier Lamy <ol...@apache.org>.
Hi
LGTLM.
Related to https://issues.apache.org/jira/browse/MRM-1907 ?
Cheers
Olivier
On 4 October 2016 at 05:00, Martin <ma...@apache.org> wrote:
> Hi Olivier,
>
> I think my last commits to the master that should improve the error
> handling,
> if LDAP is not configured properly, shifted the problem to a new location.
>
> The LDAP authentication is not mandatory, if I see this correctly.
>
> Problem is, that if LDAP is not configured correctly a autowiring exception
> occurs at the next start, because the LdapConnectionFactory cannot be
> initialized. Which leads to a complete startup failure. I'm not sure, if
> this
> was the case before my commit.
>
> I think exceptions during autowiring, are only OK for mandatory beans, but
> the
> LDAPAuthenticator is not mandatory.
> My fix needs a new method isValid() of the Authenticator and
> LdapConnectionFactory-Interfaces.
> I added the fix to a new branch 'validauth' for review. Could you please
> check, if this is the right way.
> The unit tests are not checked in this branch. I will adapt them, if you
> agree
> to the implementation.
>
> Greetings
>
> Martin
>
>
>
--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy