You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2020/04/28 14:09:02 UTC

[GitHub] [mesos] greggomann commented on a change in pull request #361: Added ability to specify a root dir for boost-libs, curl and libseccomp.

greggomann commented on a change in pull request #361:
URL: https://github.com/apache/mesos/pull/361#discussion_r416643733



##########
File path: 3rdparty/CMakeLists.txt
##########
@@ -696,7 +701,16 @@ if (ENABLE_SECCOMP_ISOLATOR)
       URL               ${LIBSECCOMP_URL}
       URL_HASH          ${LIBSECCOMP_HASH})
   else ()
-    find_package(LIBSECCOMP REQUIRED)
+    if ("${LIBSECCOMP_ROOT_DIR}" STREQUAL "")
+      find_package(LIBSECCOMP REQUIRED)
+    else ()
+      set(POSSIBLE_LIBSECCOMP_INCLUDE_DIRS ${LIBSECCOMP_ROOT_DIR}/include)
+      set(POSSIBLE_LIBSECCOMP_LIB_DIRS ${LIBSECCOMP_ROOT_DIR}/lib)
+
+      set(LIBSECCOMP_LIBRARY_NAMES seccomp)
+
+      FIND_PACKAGE_HELPER(LIBSECCOMP seccomp.h)
+    endif ()

Review comment:
       Check if we can get rid of this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org