You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/04/04 22:22:30 UTC

Review Request 58190: Improved termination logging in default executor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58190/
-----------------------------------------------------------

Review request for mesos, Gast�n Kleiman and Vinod Kone.


Repository: mesos


Description
-------

WSTRINGIFY already includes a preamble in addition to exit status,
no need to repeat it.


Diffs
-----

  src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299 


Diff: https://reviews.apache.org/r/58190/diff/1/


Testing
-------

See https://reviews.apache.org/r/58196/


Thanks,

Alexander Rukletsov


Re: Review Request 58190: Improved termination logging in default executor.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58190/
-----------------------------------------------------------

(Updated April 19, 2017, 3:15 p.m.)


Review request for mesos, Gast�n Kleiman and Vinod Kone.


Changes
-------

Rebased. NNTR.


Repository: mesos


Description
-------

WSTRINGIFY already includes a preamble in addition to exit status,
no need to repeat it.


Diffs (updated)
-----

  src/launcher/default_executor.cpp d003c1b307c0c258fd82028ea7d932d92653e746 


Diff: https://reviews.apache.org/r/58190/diff/2/

Changes: https://reviews.apache.org/r/58190/diff/1-2/


Testing
-------

See https://reviews.apache.org/r/58196/


Thanks,

Alexander Rukletsov


Re: Review Request 58190: Improved termination logging in default executor.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58190/#review171294
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On April 4, 2017, 10:22 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58190/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 10:22 p.m.)
> 
> 
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WSTRINGIFY already includes a preamble in addition to exit status,
> no need to repeat it.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299 
> 
> 
> Diff: https://reviews.apache.org/r/58190/diff/1/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/58196/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>