You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by rob-close <gi...@git.apache.org> on 2015/02/26 20:41:46 UTC
[GitHub] cordova-plugin-file pull request: CB-8554 Updated source to pass F...
GitHub user rob-close opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/102
CB-8554 Updated source to pass Fortify scan.
From Fortify:
Access Control: SecurityManager Bypass (Security Features, Structural)
Poor Error Handling: Empty Catch Block (Errors, Structural)
Poor Style: Non-final Public Static Field (Encapsulation, Structural)
Poor Error Handling: Throw Inside Finally (Errors, Structural)
And from SonarQube:
Preserve Stack Trace
Reliance on default encoding
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob-close/cordova-plugin-file CB-8554
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit 05d767a31f2ae9ae380b55cbdcf8d6b675f90f33
Author: Rob Close <rob-close>
Date: 2015-02-26T19:30:48Z
CB-8554 Updated source to pass Fortify scan.
From Fortify:
Access Control: SecurityManager Bypass (Security Features, Structural)
Poor Error Handling: Empty Catch Block (Errors, Structural)
Poor Style: Non-final Public Static Field (Encapsulation, Structural)
Poor Error Handling: Throw Inside Finally (Errors, Structural)
And from SonarQube:
Preserve Stack Trace
Reliance on default encoding
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8554 Updated source to pass F...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/102#issuecomment-82477043
Changes look good I think, but I've sadly landed some code before looking at this that causes it to not merge cleanly. Would you be able to rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8554 Updated source to pass F...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/102#issuecomment-149738253
*bump*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request #102: CB-8554 Updated source to pass Fortif...
Posted by rob-close <gi...@git.apache.org>.
Github user rob-close closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org